You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Riza Suminto (Code Review)" <ge...@cloudera.org> on 2025/03/06 16:54:35 UTC

[Impala-ASF-CR] IMPALA-12931: (Addendum) Retry test no hms event incremental refresh

Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/22590


Change subject: IMPALA-12931: (Addendum) Retry test_no_hms_event_incremental_refresh
......................................................................

IMPALA-12931: (Addendum) Retry test_no_hms_event_incremental_refresh

test_no_hms_event_incremental_refresh_transactional_table still flaky
even after adding statestore heartbeat wait. This patch make the test
retries the select query if expected result has not been observed.

Testing:
- Loop and pass the tests 10 times.

Change-Id: I01f9bd3664237e3152ccd8f1cac4b226deb117d0
---
M tests/custom_cluster/test_events_custom_configs.py
1 file changed, 14 insertions(+), 4 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/90/22590/1
-- 
To view, visit http://gerrit.cloudera.org:8080/22590
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I01f9bd3664237e3152ccd8f1cac4b226deb117d0
Gerrit-Change-Number: 22590
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>

[Impala-ASF-CR] IMPALA-12931: (Addendum) Slow test no hms event incremental refresh

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22590 )

Change subject: IMPALA-12931: (Addendum) Slow test_no_hms_event_incremental_refresh
......................................................................


Patch Set 3:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/18496/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/22590
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I01f9bd3664237e3152ccd8f1cac4b226deb117d0
Gerrit-Change-Number: 22590
Gerrit-PatchSet: 3
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 06 Mar 2025 18:07:06 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12931: (Addendum) Retry test no hms event incremental refresh

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22590 )

Change subject: IMPALA-12931: (Addendum) Retry test_no_hms_event_incremental_refresh
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/18493/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/22590
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I01f9bd3664237e3152ccd8f1cac4b226deb117d0
Gerrit-Change-Number: 22590
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 06 Mar 2025 17:20:48 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12931: (Addendum) Slow test no hms event incremental refresh

Posted by "Jason Fehr (Code Review)" <ge...@cloudera.org>.
Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/22590 )

Change subject: IMPALA-12931: (Addendum) Slow test_no_hms_event_incremental_refresh
......................................................................


Patch Set 3: Code-Review+2

(2 comments)

http://gerrit.cloudera.org:8080/#/c/22590/3/tests/custom_cluster/test_events_custom_configs.py
File tests/custom_cluster/test_events_custom_configs.py:

http://gerrit.cloudera.org:8080/#/c/22590/3/tests/custom_cluster/test_events_custom_configs.py@55
PS3, Line 55: def wait_statestore_heartbeat(num_heartbeat=1):
Nit: would be good to combine this code and the changes from https://gerrit.cloudera.org/c/22584/ into a single function, but that can be handled later.


http://gerrit.cloudera.org:8080/#/c/22590/3/tests/custom_cluster/test_events_custom_configs.py@1286
PS3, Line 1286:         "ACID table is not updated. Create statement: {}").format(create_stmt)
Nit: the query id can be very helpful as well as it enables quickly searching all logs from a build.



-- 
To view, visit http://gerrit.cloudera.org:8080/22590
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I01f9bd3664237e3152ccd8f1cac4b226deb117d0
Gerrit-Change-Number: 22590
Gerrit-PatchSet: 3
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 06 Mar 2025 18:00:00 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-12931: (Addendum) Slow test no hms event incremental refresh

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/22590 )

Change subject: IMPALA-12931: (Addendum) Slow test_no_hms_event_incremental_refresh
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/22590
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I01f9bd3664237e3152ccd8f1cac4b226deb117d0
Gerrit-Change-Number: 22590
Gerrit-PatchSet: 3
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 06 Mar 2025 18:19:04 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12931: (Addendum) Slow test no hms event incremental refresh

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22590 )

Change subject: IMPALA-12931: (Addendum) Slow test_no_hms_event_incremental_refresh
......................................................................


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/11571/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/22590
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I01f9bd3664237e3152ccd8f1cac4b226deb117d0
Gerrit-Change-Number: 22590
Gerrit-PatchSet: 3
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 06 Mar 2025 18:14:57 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12931: (Addendum) Slow test no hms event incremental refresh

Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22590 )

Change subject: IMPALA-12931: (Addendum) Slow test_no_hms_event_incremental_refresh
......................................................................


Patch Set 3:

(2 comments)

Thank you for the review!

http://gerrit.cloudera.org:8080/#/c/22590/3/tests/custom_cluster/test_events_custom_configs.py
File tests/custom_cluster/test_events_custom_configs.py:

http://gerrit.cloudera.org:8080/#/c/22590/3/tests/custom_cluster/test_events_custom_configs.py@55
PS3, Line 55: def wait_statestore_heartbeat(num_heartbeat=1):
> Nit: would be good to combine this code and the changes from https://gerrit
Ack. Will do it in separate patch.


http://gerrit.cloudera.org:8080/#/c/22590/3/tests/custom_cluster/test_events_custom_configs.py@1286
PS3, Line 1286:         "ACID table is not updated. Create statement: {}").format(create_stmt)
> Nit: the query id can be very helpful as well as it enables quickly searchi
Query ID and all other SQL will still show up in jenkins. This just to help next triager to see immediately if the partitioned or the non-partitioned case was failed.



-- 
To view, visit http://gerrit.cloudera.org:8080/22590
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I01f9bd3664237e3152ccd8f1cac4b226deb117d0
Gerrit-Change-Number: 22590
Gerrit-PatchSet: 3
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 06 Mar 2025 18:14:36 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-12931: (Addendum) Retry test no hms event incremental refresh

Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Hello Jason Fehr, Csaba Ringhofer, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/22590

to look at the new patch set (#2).

Change subject: IMPALA-12931: (Addendum) Retry test_no_hms_event_incremental_refresh
......................................................................

IMPALA-12931: (Addendum) Retry test_no_hms_event_incremental_refresh

test_no_hms_event_incremental_refresh_transactional_table still flaky
even after adding statestore heartbeat wait. This patch make the test
retries the select query if expected result has not been observed. Also
increased wait time to 3x statestore heartbeat period.

Testing:
- Loop and pass the tests 10 times.

Change-Id: I01f9bd3664237e3152ccd8f1cac4b226deb117d0
---
M tests/custom_cluster/test_events_custom_configs.py
1 file changed, 20 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/90/22590/2
-- 
To view, visit http://gerrit.cloudera.org:8080/22590
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I01f9bd3664237e3152ccd8f1cac4b226deb117d0
Gerrit-Change-Number: 22590
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>

[Impala-ASF-CR] IMPALA-12931: (Addendum) Slow test no hms event incremental refresh

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22590 )

Change subject: IMPALA-12931: (Addendum) Slow test_no_hms_event_incremental_refresh
......................................................................


Patch Set 3: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/22590
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I01f9bd3664237e3152ccd8f1cac4b226deb117d0
Gerrit-Change-Number: 22590
Gerrit-PatchSet: 3
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 06 Mar 2025 23:34:39 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12931: (Addendum) Retry test no hms event incremental refresh

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22590 )

Change subject: IMPALA-12931: (Addendum) Retry test_no_hms_event_incremental_refresh
......................................................................


Patch Set 2:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/18494/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/22590
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I01f9bd3664237e3152ccd8f1cac4b226deb117d0
Gerrit-Change-Number: 22590
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 06 Mar 2025 17:41:50 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12931: (Addendum) Slow test no hms event incremental refresh

Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Hello Jason Fehr, Csaba Ringhofer, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/22590

to look at the new patch set (#3).

Change subject: IMPALA-12931: (Addendum) Slow test_no_hms_event_incremental_refresh
......................................................................

IMPALA-12931: (Addendum) Slow test_no_hms_event_incremental_refresh

test_no_hms_event_incremental_refresh_transactional_table still flaky
even after adding statestore heartbeat wait. This patch increased wait
time to 4x statestore heartbeat period.

Testing:
- Loop and pass the tests 10 times.

Change-Id: I01f9bd3664237e3152ccd8f1cac4b226deb117d0
---
M tests/custom_cluster/test_events_custom_configs.py
1 file changed, 10 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/90/22590/3
-- 
To view, visit http://gerrit.cloudera.org:8080/22590
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I01f9bd3664237e3152ccd8f1cac4b226deb117d0
Gerrit-Change-Number: 22590
Gerrit-PatchSet: 3
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>

[Impala-ASF-CR] IMPALA-12931: (Addendum) Slow test no hms event incremental refresh

Posted by "Jason Fehr (Code Review)" <ge...@cloudera.org>.
Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/22590 )

Change subject: IMPALA-12931: (Addendum) Slow test_no_hms_event_incremental_refresh
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/22590/3/tests/custom_cluster/test_events_custom_configs.py
File tests/custom_cluster/test_events_custom_configs.py:

http://gerrit.cloudera.org:8080/#/c/22590/3/tests/custom_cluster/test_events_custom_configs.py@1286
PS3, Line 1286:         "ACID table is not updated. Create statement: {}").format(create_stmt)
> Query ID and all other SQL will still show up in jenkins. This just to help
Ack



-- 
To view, visit http://gerrit.cloudera.org:8080/22590
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I01f9bd3664237e3152ccd8f1cac4b226deb117d0
Gerrit-Change-Number: 22590
Gerrit-PatchSet: 3
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 06 Mar 2025 18:25:09 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-12931: (Addendum) Slow test no hms event incremental refresh

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/22590 )

Change subject: IMPALA-12931: (Addendum) Slow test_no_hms_event_incremental_refresh
......................................................................

IMPALA-12931: (Addendum) Slow test_no_hms_event_incremental_refresh

test_no_hms_event_incremental_refresh_transactional_table still flaky
even after adding statestore heartbeat wait. This patch increased wait
time to 4x statestore heartbeat period.

Testing:
- Loop and pass the tests 10 times.

Change-Id: I01f9bd3664237e3152ccd8f1cac4b226deb117d0
Reviewed-on: http://gerrit.cloudera.org:8080/22590
Reviewed-by: Jason Fehr <jf...@cloudera.com>
Reviewed-by: Csaba Ringhofer <cs...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/custom_cluster/test_events_custom_configs.py
1 file changed, 10 insertions(+), 8 deletions(-)

Approvals:
  Jason Fehr: Looks good to me, approved
  Csaba Ringhofer: Looks good to me, approved
  Impala Public Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/22590
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I01f9bd3664237e3152ccd8f1cac4b226deb117d0
Gerrit-Change-Number: 22590
Gerrit-PatchSet: 4
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>