You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/12/26 10:52:22 UTC
[GitHub] [flink] wooplevip opened a new pull request #10697:
[FLINK-15402][Formats (CSV)]Add disable quote character feature for
serializing row to csv format
wooplevip opened a new pull request #10697: [FLINK-15402][Formats (CSV)]Add disable quote character feature for serializing row to csv format
URL: https://github.com/apache/flink/pull/10697
## What is the purpose of the change
*Add disable quote character feature for serializing row to csv format*
## Brief change log
- *Add a new property "format.disable-quote-character" in CsvValidator.java*
- *Modify createSerializationSchema method in CsvRowFormatFactory to decide whether to disable quote character*
- *Add disableQuoteCharacter method in CsvRowSerializationSchema.java*
- *Add disableQuoteCharacter method in Csv.java*
- *Add test in CsvRowDeSerializationSchemaTest.java and CsvRowFormatFactoryTest.java*
## Verifying this change
This change is already covered by existing tests, and add new test case in CsvRowDeSerializationSchemaTest.java and CsvRowFormatFactoryTest.java
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes)
- The serializers: (yes)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wooplevip commented on issue #10697: [FLINK-15402][Formats
(CSV)]Add disable quote character feature for serializing row to csv format
Posted by GitBox <gi...@apache.org>.
wooplevip commented on issue #10697: [FLINK-15402][Formats (CSV)]Add disable quote character feature for serializing row to csv format
URL: https://github.com/apache/flink/pull/10697#issuecomment-580983023
Hi @dawidwys ,
Thanks for your review. I had updated codes. Please help to review, thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10697:
[FLINK-15402][Formats (CSV)]Add disable quote character feature for
serializing row to csv format
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10697: [FLINK-15402][Formats (CSV)]Add disable quote character feature for serializing row to csv format
URL: https://github.com/apache/flink/pull/10697#issuecomment-569041985
<!--
Meta data
Hash:767f1df74309c831ee9910bacf2d47cef94f7a82 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142370089 TriggerType:PUSH TriggerID:767f1df74309c831ee9910bacf2d47cef94f7a82
Hash:767f1df74309c831ee9910bacf2d47cef94f7a82 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3932 TriggerType:PUSH TriggerID:767f1df74309c831ee9910bacf2d47cef94f7a82
Hash:683e127bae3b1580626b5b1cff30cca2b961f5ed Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/147019704 TriggerType:PUSH TriggerID:683e127bae3b1580626b5b1cff30cca2b961f5ed
Hash:683e127bae3b1580626b5b1cff30cca2b961f5ed Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4746 TriggerType:PUSH TriggerID:683e127bae3b1580626b5b1cff30cca2b961f5ed
-->
## CI report:
* 767f1df74309c831ee9910bacf2d47cef94f7a82 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142370089) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3932)
* 683e127bae3b1580626b5b1cff30cca2b961f5ed Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/147019704) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4746)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10697:
[FLINK-15402][Formats (CSV)]Add disable quote character feature for
serializing row to csv format
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10697: [FLINK-15402][Formats (CSV)]Add disable quote character feature for serializing row to csv format
URL: https://github.com/apache/flink/pull/10697#issuecomment-569041985
<!--
Meta data
Hash:767f1df74309c831ee9910bacf2d47cef94f7a82 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/142370089 TriggerType:PUSH TriggerID:767f1df74309c831ee9910bacf2d47cef94f7a82
Hash:767f1df74309c831ee9910bacf2d47cef94f7a82 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3932 TriggerType:PUSH TriggerID:767f1df74309c831ee9910bacf2d47cef94f7a82
-->
## CI report:
* 767f1df74309c831ee9910bacf2d47cef94f7a82 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/142370089) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3932)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10697: [FLINK-15402][Formats
(CSV)]Add disable quote character feature for serializing row to csv format
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10697: [FLINK-15402][Formats (CSV)]Add disable quote character feature for serializing row to csv format
URL: https://github.com/apache/flink/pull/10697#issuecomment-569041985
<!--
Meta data
Hash:767f1df74309c831ee9910bacf2d47cef94f7a82 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:767f1df74309c831ee9910bacf2d47cef94f7a82
-->
## CI report:
* 767f1df74309c831ee9910bacf2d47cef94f7a82 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10697:
[FLINK-15402][Formats (CSV)]Add disable quote character feature for
serializing row to csv format
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10697: [FLINK-15402][Formats (CSV)]Add disable quote character feature for serializing row to csv format
URL: https://github.com/apache/flink/pull/10697#issuecomment-569041985
<!--
Meta data
Hash:767f1df74309c831ee9910bacf2d47cef94f7a82 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142370089 TriggerType:PUSH TriggerID:767f1df74309c831ee9910bacf2d47cef94f7a82
Hash:767f1df74309c831ee9910bacf2d47cef94f7a82 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3932 TriggerType:PUSH TriggerID:767f1df74309c831ee9910bacf2d47cef94f7a82
Hash:683e127bae3b1580626b5b1cff30cca2b961f5ed Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/147019704 TriggerType:PUSH TriggerID:683e127bae3b1580626b5b1cff30cca2b961f5ed
Hash:683e127bae3b1580626b5b1cff30cca2b961f5ed Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4746 TriggerType:PUSH TriggerID:683e127bae3b1580626b5b1cff30cca2b961f5ed
Hash:290266fd274d63045a7f7a802fd5f8d20f77b8dc Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4755 TriggerType:PUSH TriggerID:290266fd274d63045a7f7a802fd5f8d20f77b8dc
Hash:290266fd274d63045a7f7a802fd5f8d20f77b8dc Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/147128654 TriggerType:PUSH TriggerID:290266fd274d63045a7f7a802fd5f8d20f77b8dc
-->
## CI report:
* 767f1df74309c831ee9910bacf2d47cef94f7a82 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142370089) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3932)
* 683e127bae3b1580626b5b1cff30cca2b961f5ed Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/147019704) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4746)
* 290266fd274d63045a7f7a802fd5f8d20f77b8dc Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/147128654) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4755)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] dawidwys commented on a change in pull request #10697:
[FLINK-15402][Formats (CSV)]Add disable quote character feature for
serializing row to csv format
Posted by GitBox <gi...@apache.org>.
dawidwys commented on a change in pull request #10697: [FLINK-15402][Formats (CSV)]Add disable quote character feature for serializing row to csv format
URL: https://github.com/apache/flink/pull/10697#discussion_r373838706
##########
File path: docs/dev/table/connect.md
##########
@@ -1442,6 +1442,8 @@ CREATE TABLE MyUserTable (
'format.field-delimiter' = ';', -- optional: field delimiter character (',' by default)
'format.line-delimiter' = '\r\n', -- optional: line delimiter ("\n" by default; otherwise
-- "\r" or "\r\n" are allowed)
+ 'format.disable-quote-character' = true,-- optional: disabled quote character for enclosing field values (false by default)
Review comment:
Could you update remaining languages? Java/Scala/Python?
Moreover in SQL DDL the value of a property must be quoted.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10697:
[FLINK-15402][Formats (CSV)]Add disable quote character feature for
serializing row to csv format
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10697: [FLINK-15402][Formats (CSV)]Add disable quote character feature for serializing row to csv format
URL: https://github.com/apache/flink/pull/10697#issuecomment-569041985
<!--
Meta data
Hash:767f1df74309c831ee9910bacf2d47cef94f7a82 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142370089 TriggerType:PUSH TriggerID:767f1df74309c831ee9910bacf2d47cef94f7a82
Hash:767f1df74309c831ee9910bacf2d47cef94f7a82 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3932 TriggerType:PUSH TriggerID:767f1df74309c831ee9910bacf2d47cef94f7a82
Hash:683e127bae3b1580626b5b1cff30cca2b961f5ed Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:683e127bae3b1580626b5b1cff30cca2b961f5ed
-->
## CI report:
* 767f1df74309c831ee9910bacf2d47cef94f7a82 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142370089) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3932)
* 683e127bae3b1580626b5b1cff30cca2b961f5ed UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10697:
[FLINK-15402][Formats (CSV)]Add disable quote character feature for
serializing row to csv format
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10697: [FLINK-15402][Formats (CSV)]Add disable quote character feature for serializing row to csv format
URL: https://github.com/apache/flink/pull/10697#issuecomment-569041985
<!--
Meta data
Hash:767f1df74309c831ee9910bacf2d47cef94f7a82 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142370089 TriggerType:PUSH TriggerID:767f1df74309c831ee9910bacf2d47cef94f7a82
Hash:767f1df74309c831ee9910bacf2d47cef94f7a82 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3932 TriggerType:PUSH TriggerID:767f1df74309c831ee9910bacf2d47cef94f7a82
-->
## CI report:
* 767f1df74309c831ee9910bacf2d47cef94f7a82 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142370089) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3932)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] dawidwys closed pull request #10697: [FLINK-15402][Formats
(CSV)]Add disable quote character feature for serializing row to csv format
Posted by GitBox <gi...@apache.org>.
dawidwys closed pull request #10697: [FLINK-15402][Formats (CSV)]Add disable quote character feature for serializing row to csv format
URL: https://github.com/apache/flink/pull/10697
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10697:
[FLINK-15402][Formats (CSV)]Add disable quote character feature for
serializing row to csv format
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10697: [FLINK-15402][Formats (CSV)]Add disable quote character feature for serializing row to csv format
URL: https://github.com/apache/flink/pull/10697#issuecomment-569041985
<!--
Meta data
Hash:767f1df74309c831ee9910bacf2d47cef94f7a82 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142370089 TriggerType:PUSH TriggerID:767f1df74309c831ee9910bacf2d47cef94f7a82
Hash:767f1df74309c831ee9910bacf2d47cef94f7a82 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3932 TriggerType:PUSH TriggerID:767f1df74309c831ee9910bacf2d47cef94f7a82
Hash:683e127bae3b1580626b5b1cff30cca2b961f5ed Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/147019704 TriggerType:PUSH TriggerID:683e127bae3b1580626b5b1cff30cca2b961f5ed
Hash:683e127bae3b1580626b5b1cff30cca2b961f5ed Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4746 TriggerType:PUSH TriggerID:683e127bae3b1580626b5b1cff30cca2b961f5ed
-->
## CI report:
* 767f1df74309c831ee9910bacf2d47cef94f7a82 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142370089) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3932)
* 683e127bae3b1580626b5b1cff30cca2b961f5ed Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/147019704) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4746)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wooplevip commented on issue #10697: [FLINK-15402][Formats
(CSV)]Add disable quote character feature for serializing row to csv format
Posted by GitBox <gi...@apache.org>.
wooplevip commented on issue #10697: [FLINK-15402][Formats (CSV)]Add disable quote character feature for serializing row to csv format
URL: https://github.com/apache/flink/pull/10697#issuecomment-585495510
Hi @dawidwys ,
If there are any changes I need to do, please let me know anytime. Thank you.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10697: [FLINK-15402][Formats
(CSV)]Add disable quote character feature for serializing row to csv format
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10697: [FLINK-15402][Formats (CSV)]Add disable quote character feature for serializing row to csv format
URL: https://github.com/apache/flink/pull/10697#issuecomment-569037361
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 767f1df74309c831ee9910bacf2d47cef94f7a82 (Thu Dec 26 10:55:26 UTC 2019)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-15402).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wooplevip commented on a change in pull request #10697:
[FLINK-15402][Formats (CSV)]Add disable quote character feature for
serializing row to csv format
Posted by GitBox <gi...@apache.org>.
wooplevip commented on a change in pull request #10697: [FLINK-15402][Formats (CSV)]Add disable quote character feature for serializing row to csv format
URL: https://github.com/apache/flink/pull/10697#discussion_r373889518
##########
File path: docs/dev/table/connect.md
##########
@@ -1919,6 +1921,8 @@ CREATE TABLE MyUserTable (
'format.field-delimiter' = ',', -- optional: string delimiter "," by default
'format.line-delimiter' = '\n', -- optional: string delimiter "\n" by default
+ 'format.disable-quote-character' = true,-- optional: disabled quote character for enclosing field values (false by default)
Review comment:
Thanks, I will restore this code
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] dawidwys commented on a change in pull request #10697:
[FLINK-15402][Formats (CSV)]Add disable quote character feature for
serializing row to csv format
Posted by GitBox <gi...@apache.org>.
dawidwys commented on a change in pull request #10697: [FLINK-15402][Formats (CSV)]Add disable quote character feature for serializing row to csv format
URL: https://github.com/apache/flink/pull/10697#discussion_r373838626
##########
File path: docs/dev/table/connect.md
##########
@@ -1919,6 +1921,8 @@ CREATE TABLE MyUserTable (
'format.field-delimiter' = ',', -- optional: string delimiter "," by default
'format.line-delimiter' = '\n', -- optional: string delimiter "\n" by default
+ 'format.disable-quote-character' = true,-- optional: disabled quote character for enclosing field values (false by default)
Review comment:
Your change does not apply to the old csv format.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] dawidwys commented on issue #10697: [FLINK-15402][Formats
(CSV)]Add disable quote character feature for serializing row to csv format
Posted by GitBox <gi...@apache.org>.
dawidwys commented on issue #10697: [FLINK-15402][Formats (CSV)]Add disable quote character feature for serializing row to csv format
URL: https://github.com/apache/flink/pull/10697#issuecomment-585670830
Thank you for the update @wooplevip and sorry honestly forgot about it.
I rebased it and will run travis on the rebased changes. Will merge once it succeeds.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wooplevip commented on a change in pull request #10697:
[FLINK-15402][Formats (CSV)]Add disable quote character feature for
serializing row to csv format
Posted by GitBox <gi...@apache.org>.
wooplevip commented on a change in pull request #10697: [FLINK-15402][Formats (CSV)]Add disable quote character feature for serializing row to csv format
URL: https://github.com/apache/flink/pull/10697#discussion_r373890716
##########
File path: docs/dev/table/connect.md
##########
@@ -1442,6 +1442,8 @@ CREATE TABLE MyUserTable (
'format.field-delimiter' = ';', -- optional: field delimiter character (',' by default)
'format.line-delimiter' = '\r\n', -- optional: line delimiter ("\n" by default; otherwise
-- "\r" or "\r\n" are allowed)
+ 'format.disable-quote-character' = true,-- optional: disabled quote character for enclosing field values (false by default)
Review comment:
Thanks, got it. My changes do not support python.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10697:
[FLINK-15402][Formats (CSV)]Add disable quote character feature for
serializing row to csv format
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10697: [FLINK-15402][Formats (CSV)]Add disable quote character feature for serializing row to csv format
URL: https://github.com/apache/flink/pull/10697#issuecomment-569041985
<!--
Meta data
Hash:767f1df74309c831ee9910bacf2d47cef94f7a82 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142370089 TriggerType:PUSH TriggerID:767f1df74309c831ee9910bacf2d47cef94f7a82
Hash:767f1df74309c831ee9910bacf2d47cef94f7a82 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3932 TriggerType:PUSH TriggerID:767f1df74309c831ee9910bacf2d47cef94f7a82
Hash:683e127bae3b1580626b5b1cff30cca2b961f5ed Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/147019704 TriggerType:PUSH TriggerID:683e127bae3b1580626b5b1cff30cca2b961f5ed
Hash:683e127bae3b1580626b5b1cff30cca2b961f5ed Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4746 TriggerType:PUSH TriggerID:683e127bae3b1580626b5b1cff30cca2b961f5ed
Hash:290266fd274d63045a7f7a802fd5f8d20f77b8dc Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:290266fd274d63045a7f7a802fd5f8d20f77b8dc
-->
## CI report:
* 767f1df74309c831ee9910bacf2d47cef94f7a82 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142370089) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3932)
* 683e127bae3b1580626b5b1cff30cca2b961f5ed Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/147019704) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4746)
* 290266fd274d63045a7f7a802fd5f8d20f77b8dc UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10697:
[FLINK-15402][Formats (CSV)]Add disable quote character feature for
serializing row to csv format
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10697: [FLINK-15402][Formats (CSV)]Add disable quote character feature for serializing row to csv format
URL: https://github.com/apache/flink/pull/10697#issuecomment-569041985
<!--
Meta data
Hash:767f1df74309c831ee9910bacf2d47cef94f7a82 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142370089 TriggerType:PUSH TriggerID:767f1df74309c831ee9910bacf2d47cef94f7a82
Hash:767f1df74309c831ee9910bacf2d47cef94f7a82 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3932 TriggerType:PUSH TriggerID:767f1df74309c831ee9910bacf2d47cef94f7a82
Hash:683e127bae3b1580626b5b1cff30cca2b961f5ed Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/147019704 TriggerType:PUSH TriggerID:683e127bae3b1580626b5b1cff30cca2b961f5ed
Hash:683e127bae3b1580626b5b1cff30cca2b961f5ed Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4746 TriggerType:PUSH TriggerID:683e127bae3b1580626b5b1cff30cca2b961f5ed
Hash:290266fd274d63045a7f7a802fd5f8d20f77b8dc Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4755 TriggerType:PUSH TriggerID:290266fd274d63045a7f7a802fd5f8d20f77b8dc
Hash:290266fd274d63045a7f7a802fd5f8d20f77b8dc Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/147128654 TriggerType:PUSH TriggerID:290266fd274d63045a7f7a802fd5f8d20f77b8dc
-->
## CI report:
* 767f1df74309c831ee9910bacf2d47cef94f7a82 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142370089) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3932)
* 683e127bae3b1580626b5b1cff30cca2b961f5ed Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/147019704) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4746)
* 290266fd274d63045a7f7a802fd5f8d20f77b8dc Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/147128654) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4755)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10697:
[FLINK-15402][Formats (CSV)]Add disable quote character feature for
serializing row to csv format
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10697: [FLINK-15402][Formats (CSV)]Add disable quote character feature for serializing row to csv format
URL: https://github.com/apache/flink/pull/10697#issuecomment-569041985
<!--
Meta data
Hash:767f1df74309c831ee9910bacf2d47cef94f7a82 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142370089 TriggerType:PUSH TriggerID:767f1df74309c831ee9910bacf2d47cef94f7a82
Hash:767f1df74309c831ee9910bacf2d47cef94f7a82 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3932 TriggerType:PUSH TriggerID:767f1df74309c831ee9910bacf2d47cef94f7a82
Hash:683e127bae3b1580626b5b1cff30cca2b961f5ed Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/147019704 TriggerType:PUSH TriggerID:683e127bae3b1580626b5b1cff30cca2b961f5ed
Hash:683e127bae3b1580626b5b1cff30cca2b961f5ed Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4746 TriggerType:PUSH TriggerID:683e127bae3b1580626b5b1cff30cca2b961f5ed
-->
## CI report:
* 767f1df74309c831ee9910bacf2d47cef94f7a82 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142370089) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3932)
* 683e127bae3b1580626b5b1cff30cca2b961f5ed Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/147019704) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4746)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services