You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@sdap.apache.org by GitBox <gi...@apache.org> on 2020/08/03 19:39:47 UTC

[GitHub] [incubator-sdap-ingester] eamonford commented on pull request #7: SDAP-269: Maintain an asynchronous connection to RabbitMQ in collection-manager, rather than a blocking one

eamonford commented on pull request #7:
URL: https://github.com/apache/incubator-sdap-ingester/pull/7#issuecomment-668205691


   > Ok, Eamon.
   > I run the unit tests. I notice that we now have a dependency on the common package.
   > I think you could add that in the README file. Like for unit test:
   > 
   > cd ../common
   > pip install -e .
   > 
   > cd ../collection_manager
   > pytest
   > 
   > Thanks
   
   Good suggestion -- I will add it into the readme file.
   
   The reason I added the common module is because I added a few helper functions for unit testing async methods, which will soon be used in the unit tests for the other modules as well.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org