[GitHub] [druid] clintropolis commented on a change in pull request #10060: More prominent instructions on code coverage failure

[GitBox <gi...@apache.org>]

clintropolis commented on a change in pull request #10060:
URL: https://github.com/apache/druid/pull/10060#discussion_r445252568



##########
File path: .travis.yml
##########
@@ -183,7 +183,7 @@ jobs:
           --log-template "totals-complete"
           --log-template "errors"
           --
-          || { printf "\nDiff code coverage check failed. To view coverage report, run 'mvn clean test jacoco:report' and open 'target/site/jacoco/index.html'\n" && false; }
+          || { printf "\n\n****FAILED****\nDiff code coverage check failed. To view coverage report, run 'mvn clean test jacoco:report' and open 'target/site/jacoco/index.html'\nFor more instructions on how to run code coverage locally, follow instructions here - https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md#running-code-coverage-locally\n\n" && false; }

Review comment:
       nit: "For more instructions on how to run code coverage locally, follow instructions.." reads sort of funny, maybe one of the 'instructions' should be replaced with 'details' or some other word?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org