You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2018/12/17 14:44:22 UTC

[GitHub] hequn8128 commented on a change in pull request #7315: [FLINK-11179][tests] add wait time for every record for testCancelSor…

hequn8128 commented on a change in pull request #7315: [FLINK-11179][tests] add wait time for every record for testCancelSor…
URL: https://github.com/apache/flink/pull/7315#discussion_r242173110
 
 

 ##########
 File path: flink-tests/src/test/java/org/apache/flink/test/cancelling/JoinCancelingITCase.java
 ##########
 @@ -122,9 +122,11 @@ public void testCancelSortMatchWithHighparallelism() throws Exception {
 
 	private static final class SimpleMatcher<IN> implements JoinFunction<Tuple2<IN, IN>, Tuple2<IN, IN>, Tuple2<IN, IN>> {
 		private static final long serialVersionUID = 1L;
+		private static final int WAIT_TIME_PER_RECORD = 300; // 0.3 sec.
 
 Review comment:
   @sunjincheng121 Thanks for reporting and fixing the problem. 
   How about make delay configurable in `DelayingMatcher`? Keep `SimpleMatcher` as what it is, i.e, keep it simple. 
   
   Best, Hequn

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services