[jira] Updated: (SHINDIG-1190) userprefs don't get saved

["Benjamin McCann (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SHINDIG-1190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Benjamin McCann updated SHINDIG-1190:
-------------------------------------

    Attachment: test.html

This change needs to be reverted.  The inputs generated by the prefs dialog script are not hidden as demonstrated by the attached file.  You do not want to skip all non-hidden fields.

> userprefs don't get saved
> -------------------------
>
>                 Key: SHINDIG-1190
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1190
>             Project: Shindig
>          Issue Type: Bug
>          Components: Javascript 
>            Reporter: Christiaan Hees
>            Priority: Trivial
>             Fix For: 1.1-BETA4
>
>         Attachments: test.html
>
>   Original Estimate: 0.08h
>  Remaining Estimate: 0.08h
>
> At shindig/javascript/container/gadgets.js:639 in the handleSaveUserPrefs it makes this check:
> if (input.type != 'hidden')
> I think this should actually be:
> if (input.type == 'hidden')
> cause at the moment it actually skips all the relevant fields which results in prefs being empty and thus not getting saved.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.