[jira] [Commented] (GEODE-3319) Use protobuf serialization for primitive types

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GEODE-3319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16103897#comment-16103897 ] 

ASF GitHub Bot commented on GEODE-3319:
---------------------------------------

GitHub user WireBaron opened a pull request:

    https://github.com/apache/geode/pull/661

    GEODE-3319 - refactor to use protobuf encoding for primitive types

    @pivotal-amurmann @galen-pivotal @hiteshk25 @kohlmu-pivotal @bschuchardt 
    
    This changes protobuf EncodedValue messages to store data formats that protobuf can natively recognize as those types and only use byte encoding for more complicated object types.
    
    Signed-off-by: Brian Rowe <br...@pivotal.io>
    Signed-off-by: Hitesh Khamesra <hi...@yahoo.com>
    Signed-off-by: Udo Kohlmeyer <ud...@apache.org>
    
    Thank you for submitting a contribution to Apache Geode.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
    
    - [x] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
    
    - [x] Is your initial contribution a single, squashed commit?
    
    - [x] Does `gradlew build` run cleanly?
    
    - [x] Have you written or updated unit tests to verify your changes?
    
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and
    submit an update to your PR as soon as possible. If you need help, please send an
    email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/WireBaron/geode feature/GEODE-3319

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/geode/pull/661.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #661
    
----
commit 48aadab39a5f3cf1714a40c743dc9f2f0590bc3a
Author: Hitesh Khamesra <hi...@yahoo.com>
Date:   2017-07-27T00:49:27Z

    GEODE-3319 - refactor to use protobuf encoding for primitive types
    
    Signed-off-by: Hitesh Khamesra <hi...@yahoo.com>
    Signed-off-by: Udo Kohlmeyer <ud...@apache.org>
    Signed-off-by: Brian Rowe <br...@pivotal.io>

----


> Use protobuf serialization for primitive types
> ----------------------------------------------
>
>                 Key: GEODE-3319
>                 URL: https://issues.apache.org/jira/browse/GEODE-3319
>             Project: Geode
>          Issue Type: Improvement
>          Components: client/server
>            Reporter: Brian Baynes
>
> As a developer using the new protocol to write a new client, I'd rather not worry about binary encoding or endianness of primitives.
> Use protobuf for serialization of primitive types, which will take some burden off of the client and eliminate the problem of language-to-language endian mismatches.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)