You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gearpump.apache.org by manuzhang <gi...@git.apache.org> on 2018/04/22 07:20:13 UTC
[GitHub] incubator-gearpump pull request #243: [GEARPUMP-339] Fix unknown tag paramet...
GitHub user manuzhang opened a pull request:
https://github.com/apache/incubator-gearpump/pull/243
[GEARPUMP-339] Fix unknown tag parameter
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the commit message is formatted like:
`[GEARPUMP-<Jira issue #>] Meaningful description of pull request`
- [ ] Make sure tests pass via `sbt clean test`.
- [ ] Make sure old documentation affected by the pull request has been updated and new documentation added for new functionality.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/manuzhang/incubator-gearpump improve_scaladoc
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-gearpump/pull/243.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #243
----
commit 20024e1f4d43e776487cabcf67632d644fab07ae
Author: manuzhang <ow...@...>
Date: 2018-04-22T07:17:51Z
[GEARPUMP-339] Fix unknown tag parameter
----
---
[GitHub] incubator-gearpump issue #243: [GEARPUMP-339] Fix unknown tag parameter
Posted by manuzhang <gi...@git.apache.org>.
Github user manuzhang commented on the issue:
https://github.com/apache/incubator-gearpump/pull/243
R: @huafengw
---
[GitHub] incubator-gearpump issue #243: [GEARPUMP-339] Fix unknown tag parameter
Posted by huafengw <gi...@git.apache.org>.
Github user huafengw commented on the issue:
https://github.com/apache/incubator-gearpump/pull/243
+1
---
[GitHub] incubator-gearpump issue #243: [GEARPUMP-339] Fix unknown tag parameter
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:
https://github.com/apache/incubator-gearpump/pull/243
# [Codecov](https://codecov.io/gh/apache/incubator-gearpump/pull/243?src=pr&el=h1) Report
> Merging [#243](https://codecov.io/gh/apache/incubator-gearpump/pull/243?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-gearpump/commit/2d13b9cf883ee59b97751d992c2b52dc4068b16c?src=pr&el=desc) will **decrease** coverage by `0.06%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #243 +/- ##
==========================================
- Coverage 68.98% 68.91% -0.07%
==========================================
Files 191 191
Lines 6171 6171
Branches 546 546
==========================================
- Hits 4257 4253 -4
- Misses 1914 1918 +4
```
---
[GitHub] incubator-gearpump pull request #243: [GEARPUMP-339] Fix unknown tag paramet...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-gearpump/pull/243
---