You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by "bowenliang123 (via GitHub)" <gi...@apache.org> on 2023/05/29 10:10:06 UTC

[GitHub] [kyuubi] bowenliang123 commented on pull request #4892: [AUTHZ] Make identifier part name comparision case insenstive in tests of PrivilegeBuilder

bowenliang123 commented on PR #4892:
URL: https://github.com/apache/kyuubi/pull/4892#issuecomment-1566897574

   Not happy with the extracted `assertEqualsIgnoreCase` methond in `AssertionUtils`. When assertion fails inside `AssertionUtils`, there's no enough hints for the suite class and the line number. Like,
   ```
   - MergeIntoTable *** FAILED ***
     Expected "[v2jdbctablecatalogprivilegesbuildersuite]", but got "[catalog_ns]" (AssertionUtils.scala:26)
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org