You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/04/17 03:58:48 UTC

[GitHub] [flink] godfreyhe opened a new pull request, #19497: [FLINK-27272][table-planner] Fix the incorrect plan for query with local sort is incorrect if adaptive batch scheduler is enabled

godfreyhe opened a new pull request, #19497:
URL: https://github.com/apache/flink/pull/19497

   ## What is the purpose of the change
   
   *See the bug detail in the JIRA description. The solution is 1) correct the RequireDistribution derivation for local BatchPhysicalRank, 2) add logic in ForwardHashExchangeProcessor to handle local sort case*
   
   
   ## Brief change log
   
     - *correct the RequireDistribution derivation for local BatchPhysicalRank*
     - *add logic in ForwardHashExchangeProcessor to handle local sort case*
   
   
   ## Verifying this change
   
   Please make sure both new and modified tests in this PR follows the conventions defined in our code quality guide: https://flink.apache.org/contributing/code-style-and-quality-common.html#testing
   
   This change added tests and can be verified as follows:
   
     - *Extended ForwardHashExchangeTest to verify the change*
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / **no** / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (not applicable / docs / JavaDocs / **not documented**)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] wenlong88 commented on pull request #19497: [FLINK-27272][table-planner] Fix the incorrect plan for query with local sort is incorrect if adaptive batch scheduler is enabled

Posted by GitBox <gi...@apache.org>.
wenlong88 commented on PR #19497:
URL: https://github.com/apache/flink/pull/19497#issuecomment-1101025641

   LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #19497: [FLINK-27272][table-planner] Fix the incorrect plan for query with local sort is incorrect if adaptive batch scheduler is enabled

Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #19497:
URL: https://github.com/apache/flink/pull/19497#issuecomment-1100798464

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "551d5dba13bb93ac1a754302003675f756945105",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "551d5dba13bb93ac1a754302003675f756945105",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 551d5dba13bb93ac1a754302003675f756945105 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] godfreyhe closed pull request #19497: [FLINK-27272][table-planner] Fix the incorrect plan for query with local sort is incorrect if adaptive batch scheduler is enabled

Posted by GitBox <gi...@apache.org>.
godfreyhe closed pull request #19497: [FLINK-27272][table-planner] Fix the incorrect plan for query with local sort is incorrect if adaptive batch scheduler is enabled
URL: https://github.com/apache/flink/pull/19497


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org