You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/04/17 13:51:13 UTC

[GitHub] [flink] azagrebin commented on issue #8191: [FLINK-12213][network] Pass TaskManagerMetricGroup into constructor of NetworkEnvironment

azagrebin commented on issue #8191: [FLINK-12213][network] Pass TaskManagerMetricGroup into constructor of NetworkEnvironment
URL: https://github.com/apache/flink/pull/8191#issuecomment-484098571
 
 
   @zhijiangW 
   As for tests, as long as the `getNetworkBufferPool` is not part shuffle API and used only in internal tests of `NetworkEnvironment`, it is fine for the scope of shuffle refactoring. Further on, we can of course simplify it as well or use the constructor with created dependencies as I suggested in one of my comments. Maybe, it could a separate commit here.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services