You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/12/14 15:01:54 UTC

[GitHub] [kafka] ijuma opened a new pull request #9747: KAFKA-10852: AlterIsr should be a cluster action

ijuma opened a new pull request #9747:
URL: https://github.com/apache/kafka/pull/9747


   This ensures it won't get throttled.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] mumrah commented on pull request #9747: KAFKA-10852: AlterIsr should not be throttled

Posted by GitBox <gi...@apache.org>.
mumrah commented on pull request #9747:
URL: https://github.com/apache/kafka/pull/9747#issuecomment-744728578


   @ijuma, thanks! So, we'll keep the throttle field in the RPC, but we won't actually set the throttle. Seems reasonable 👍 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] ijuma commented on pull request #9747: KAFKA-10852: AlterIsr should not be throttled

Posted by GitBox <gi...@apache.org>.
ijuma commented on pull request #9747:
URL: https://github.com/apache/kafka/pull/9747#issuecomment-745082940


   Unrelated flaky test failures:
   
   > Build / JDK 11 / kafka.server.ScramServerStartupTest.testAuthentications
   > Build / JDK 15 / org.apache.kafka.streams.integration.StandbyTaskEOSIntegrationTest.shouldWipeOutStandbyStateDirectoryIfCheckpointIsMissing[exactly_once]
   > 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] ijuma commented on a change in pull request #9747: KAFKA-10852: AlterIsr should be a cluster action

Posted by GitBox <gi...@apache.org>.
ijuma commented on a change in pull request #9747:
URL: https://github.com/apache/kafka/pull/9747#discussion_r542452727



##########
File path: clients/src/test/java/org/apache/kafka/common/protocol/ApiKeysTest.java
##########
@@ -55,11 +61,14 @@ public void schemaVersionOutOfRange() {
      */
     @Test
     public void testResponseThrottleTime() {
-        List<ApiKeys> authenticationKeys = Arrays.asList(ApiKeys.SASL_HANDSHAKE, ApiKeys.SASL_AUTHENTICATE);
+        Set<ApiKeys> authenticationKeys = EnumSet.of(ApiKeys.SASL_HANDSHAKE, ApiKeys.SASL_AUTHENTICATE);
+        // Newer protocol apis include throttle time ms even for cluster actions
+        Set<ApiKeys> clusterActionsWithThrottleTimeMs = EnumSet.of(ApiKeys.ALTER_ISR);

Review comment:
       We have to decide whether we want to do this or remove the throttle time ms from AlterIsr before 2.7.0.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] ijuma commented on pull request #9747: KAFKA-10852: AlterIsr should not be throttled

Posted by GitBox <gi...@apache.org>.
ijuma commented on pull request #9747:
URL: https://github.com/apache/kafka/pull/9747#issuecomment-744700378


   @mumrah A couple of the test failures indicated that we had to change some code in KafkaApis too. Updated.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] ijuma commented on a change in pull request #9747: KAFKA-10852: AlterIsr should be a cluster action

Posted by GitBox <gi...@apache.org>.
ijuma commented on a change in pull request #9747:
URL: https://github.com/apache/kafka/pull/9747#discussion_r542751216



##########
File path: clients/src/test/java/org/apache/kafka/common/protocol/ApiKeysTest.java
##########
@@ -55,11 +61,14 @@ public void schemaVersionOutOfRange() {
      */
     @Test
     public void testResponseThrottleTime() {
-        List<ApiKeys> authenticationKeys = Arrays.asList(ApiKeys.SASL_HANDSHAKE, ApiKeys.SASL_AUTHENTICATE);
+        Set<ApiKeys> authenticationKeys = EnumSet.of(ApiKeys.SASL_HANDSHAKE, ApiKeys.SASL_AUTHENTICATE);
+        // Newer protocol apis include throttle time ms even for cluster actions
+        Set<ApiKeys> clusterActionsWithThrottleTimeMs = EnumSet.of(ApiKeys.ALTER_ISR);

Review comment:
       We decided this is not a blocker.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] ijuma merged pull request #9747: KAFKA-10852: AlterIsr should not be throttled

Posted by GitBox <gi...@apache.org>.
ijuma merged pull request #9747:
URL: https://github.com/apache/kafka/pull/9747


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] ijuma commented on a change in pull request #9747: KAFKA-10852: AlterIsr should be a cluster action

Posted by GitBox <gi...@apache.org>.
ijuma commented on a change in pull request #9747:
URL: https://github.com/apache/kafka/pull/9747#discussion_r542452824



##########
File path: clients/src/test/java/org/apache/kafka/common/protocol/ApiKeysTest.java
##########
@@ -55,11 +61,14 @@ public void schemaVersionOutOfRange() {
      */
     @Test
     public void testResponseThrottleTime() {
-        List<ApiKeys> authenticationKeys = Arrays.asList(ApiKeys.SASL_HANDSHAKE, ApiKeys.SASL_AUTHENTICATE);
+        Set<ApiKeys> authenticationKeys = EnumSet.of(ApiKeys.SASL_HANDSHAKE, ApiKeys.SASL_AUTHENTICATE);
+        // Newer protocol apis include throttle time ms even for cluster actions
+        Set<ApiKeys> clusterActionsWithThrottleTimeMs = EnumSet.of(ApiKeys.ALTER_ISR);

Review comment:
       cc @bbejeck 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] ijuma commented on pull request #9747: KAFKA-10852: AlterIsr should not be throttled

Posted by GitBox <gi...@apache.org>.
ijuma commented on pull request #9747:
URL: https://github.com/apache/kafka/pull/9747#issuecomment-745087259


   Merged to trunk and 2.7 branches.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org