You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Dmytro Sen <ds...@hortonworks.com> on 2014/11/27 12:41:19 UTC
Review Request 28512: Ambari agent should catch all exceptions which
raised
during bootstrap agent process and traceback they only if it "-v" was setup
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28512/
-----------------------------------------------------------
Review request for Ambari, Dmitro Lisnichenko and Jeff Sposetti.
Bugs: AMBARI-8562
https://issues.apache.org/jira/browse/AMBARI-8562
Repository: ambari
Description
-------
Ambari agent should restart with -v option if previous ambari-agent process was run with -v option. Accordinly this option we shoul show/hide traceback.
How it will work:
1) ambari-agent always have been restarted even if ambari-agent didn't started before, so we should restart ambari-agent with '-v' option if previous process of ambari-agent was started with '-v'
2) If '-v' option is not defined in command line all exceptions with tracebacks, which rised while setup of ambari-agent, will be showed in output, othewise only error messages will be showed in output.
Diffs
-----
ambari-server/src/main/python/os_check_type.py f890504
ambari-server/src/main/python/setupAgent.py ede83c5
ambari-server/src/test/python/TestOSCheck.py 20b8890
ambari-server/src/test/python/TestSetupAgent.py 8293fd0
Diff: https://reviews.apache.org/r/28512/diff/
Testing
-------
tests passed
Thanks,
Dmytro Sen
Re: Review Request 28512: Ambari agent should catch all exceptions
which
raised during bootstrap agent process and traceback they only if it "-v"
was setup
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28512/#review64007
-----------------------------------------------------------
Ship it!
Ship It!
- Nate Cole
On Nov. 27, 2014, 10:57 a.m., Dmytro Sen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28512/
> -----------------------------------------------------------
>
> (Updated Nov. 27, 2014, 10:57 a.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko, John Speidel, Mahadev Konar, Nate Cole, and Jeff Sposetti.
>
>
> Bugs: AMBARI-8562
> https://issues.apache.org/jira/browse/AMBARI-8562
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Ambari agent should restart with -v option if previous ambari-agent process was run with -v option. Accordinly this option we shoul show/hide traceback.
> How it will work:
> 1) ambari-agent always have been restarted even if ambari-agent didn't started before, so we should restart ambari-agent with '-v' option if previous process of ambari-agent was started with '-v'
> 2) If '-v' option is not defined in command line all exceptions with tracebacks, which rised while setup of ambari-agent, will be showed in output, othewise only error messages will be showed in output.
>
>
> Diffs
> -----
>
> ambari-server/src/main/python/os_check_type.py f890504
> ambari-server/src/main/python/setupAgent.py ede83c5
> ambari-server/src/test/python/TestOSCheck.py 20b8890
> ambari-server/src/test/python/TestSetupAgent.py 8293fd0
>
> Diff: https://reviews.apache.org/r/28512/diff/
>
>
> Testing
> -------
>
> tests passed
>
>
> Thanks,
>
> Dmytro Sen
>
>
Re: Review Request 28512: Ambari agent should catch all exceptions
which
raised during bootstrap agent process and traceback they only if it "-v"
was setup
Posted by Dmytro Sen <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28512/
-----------------------------------------------------------
(Updated Янв. 23, 2015, 1:06 п.п.)
Review request for Ambari, Dmitro Lisnichenko, John Speidel, Mahadev Konar, Nate Cole, and Jeff Sposetti.
Bugs: AMBARI-8462
https://issues.apache.org/jira/browse/AMBARI-8462
Repository: ambari
Description
-------
Ambari agent should restart with -v option if previous ambari-agent process was run with -v option. Accordinly this option we shoul show/hide traceback.
How it will work:
1) ambari-agent always have been restarted even if ambari-agent didn't started before, so we should restart ambari-agent with '-v' option if previous process of ambari-agent was started with '-v'
2) If '-v' option is not defined in command line all exceptions with tracebacks, which rised while setup of ambari-agent, will be showed in output, othewise only error messages will be showed in output.
Diffs
-----
ambari-server/src/main/python/os_check_type.py f890504
ambari-server/src/main/python/setupAgent.py ede83c5
ambari-server/src/test/python/TestOSCheck.py 20b8890
ambari-server/src/test/python/TestSetupAgent.py 8293fd0
Diff: https://reviews.apache.org/r/28512/diff/
Testing
-------
tests passed
Thanks,
Dmytro Sen
Re: Review Request 28512: Ambari agent should catch all exceptions
which
raised during bootstrap agent process and traceback they only if it "-v"
was setup
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28512/#review63237
-----------------------------------------------------------
Ship it!
Ship It!
- Dmitro Lisnichenko
On Nov. 27, 2014, 3:57 p.m., Dmytro Sen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28512/
> -----------------------------------------------------------
>
> (Updated Nov. 27, 2014, 3:57 p.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko, John Speidel, Mahadev Konar, Nate Cole, and Jeff Sposetti.
>
>
> Bugs: AMBARI-8562
> https://issues.apache.org/jira/browse/AMBARI-8562
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Ambari agent should restart with -v option if previous ambari-agent process was run with -v option. Accordinly this option we shoul show/hide traceback.
> How it will work:
> 1) ambari-agent always have been restarted even if ambari-agent didn't started before, so we should restart ambari-agent with '-v' option if previous process of ambari-agent was started with '-v'
> 2) If '-v' option is not defined in command line all exceptions with tracebacks, which rised while setup of ambari-agent, will be showed in output, othewise only error messages will be showed in output.
>
>
> Diffs
> -----
>
> ambari-server/src/main/python/os_check_type.py f890504
> ambari-server/src/main/python/setupAgent.py ede83c5
> ambari-server/src/test/python/TestOSCheck.py 20b8890
> ambari-server/src/test/python/TestSetupAgent.py 8293fd0
>
> Diff: https://reviews.apache.org/r/28512/diff/
>
>
> Testing
> -------
>
> tests passed
>
>
> Thanks,
>
> Dmytro Sen
>
>
Re: Review Request 28512: Ambari agent should catch all exceptions
which
raised during bootstrap agent process and traceback they only if it "-v"
was setup
Posted by Dmytro Sen <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28512/
-----------------------------------------------------------
(Updated Ноя. 27, 2014, 3:57 п.п.)
Review request for Ambari, Dmitro Lisnichenko, John Speidel, Mahadev Konar, Nate Cole, and Jeff Sposetti.
Bugs: AMBARI-8562
https://issues.apache.org/jira/browse/AMBARI-8562
Repository: ambari
Description
-------
Ambari agent should restart with -v option if previous ambari-agent process was run with -v option. Accordinly this option we shoul show/hide traceback.
How it will work:
1) ambari-agent always have been restarted even if ambari-agent didn't started before, so we should restart ambari-agent with '-v' option if previous process of ambari-agent was started with '-v'
2) If '-v' option is not defined in command line all exceptions with tracebacks, which rised while setup of ambari-agent, will be showed in output, othewise only error messages will be showed in output.
Diffs (updated)
-----
ambari-server/src/main/python/os_check_type.py f890504
ambari-server/src/main/python/setupAgent.py ede83c5
ambari-server/src/test/python/TestOSCheck.py 20b8890
ambari-server/src/test/python/TestSetupAgent.py 8293fd0
Diff: https://reviews.apache.org/r/28512/diff/
Testing
-------
tests passed
Thanks,
Dmytro Sen
Re: Review Request 28512: Ambari agent should catch all exceptions
which
raised during bootstrap agent process and traceback they only if it "-v"
was setup
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28512/#review63230
-----------------------------------------------------------
ambari-server/src/main/python/os_check_type.py
<https://reviews.apache.org/r/28512/#comment105409>
typo
ambari-server/src/main/python/setupAgent.py
<https://reviews.apache.org/r/28512/#comment105410>
Why not just read command line parameters of running instance before stopping it? This command line could be reused when starting a new instance
- Dmitro Lisnichenko
On Nov. 27, 2014, 3 p.m., Dmytro Sen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28512/
> -----------------------------------------------------------
>
> (Updated Nov. 27, 2014, 3 p.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko, John Speidel, Mahadev Konar, Nate Cole, and Jeff Sposetti.
>
>
> Bugs: AMBARI-8562
> https://issues.apache.org/jira/browse/AMBARI-8562
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Ambari agent should restart with -v option if previous ambari-agent process was run with -v option. Accordinly this option we shoul show/hide traceback.
> How it will work:
> 1) ambari-agent always have been restarted even if ambari-agent didn't started before, so we should restart ambari-agent with '-v' option if previous process of ambari-agent was started with '-v'
> 2) If '-v' option is not defined in command line all exceptions with tracebacks, which rised while setup of ambari-agent, will be showed in output, othewise only error messages will be showed in output.
>
>
> Diffs
> -----
>
> ambari-server/src/main/python/os_check_type.py f890504
> ambari-server/src/main/python/setupAgent.py ede83c5
> ambari-server/src/test/python/TestOSCheck.py 20b8890
> ambari-server/src/test/python/TestSetupAgent.py 8293fd0
>
> Diff: https://reviews.apache.org/r/28512/diff/
>
>
> Testing
> -------
>
> tests passed
>
>
> Thanks,
>
> Dmytro Sen
>
>
Re: Review Request 28512: Ambari agent should catch all exceptions
which
raised during bootstrap agent process and traceback they only if it "-v"
was setup
Posted by Dmytro Sen <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28512/
-----------------------------------------------------------
(Updated Ноя. 27, 2014, 3 п.п.)
Review request for Ambari, Dmitro Lisnichenko, John Speidel, Mahadev Konar, Nate Cole, and Jeff Sposetti.
Bugs: AMBARI-8562
https://issues.apache.org/jira/browse/AMBARI-8562
Repository: ambari
Description
-------
Ambari agent should restart with -v option if previous ambari-agent process was run with -v option. Accordinly this option we shoul show/hide traceback.
How it will work:
1) ambari-agent always have been restarted even if ambari-agent didn't started before, so we should restart ambari-agent with '-v' option if previous process of ambari-agent was started with '-v'
2) If '-v' option is not defined in command line all exceptions with tracebacks, which rised while setup of ambari-agent, will be showed in output, othewise only error messages will be showed in output.
Diffs
-----
ambari-server/src/main/python/os_check_type.py f890504
ambari-server/src/main/python/setupAgent.py ede83c5
ambari-server/src/test/python/TestOSCheck.py 20b8890
ambari-server/src/test/python/TestSetupAgent.py 8293fd0
Diff: https://reviews.apache.org/r/28512/diff/
Testing
-------
tests passed
Thanks,
Dmytro Sen
Re: Review Request 28512: Ambari agent should catch all exceptions
which
raised during bootstrap agent process and traceback they only if it "-v"
was setup
Posted by Dmytro Sen <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28512/
-----------------------------------------------------------
(Updated Ноя. 27, 2014, 2:59 п.п.)
Review request for Ambari, Dmitro Lisnichenko, Mahadev Konar, Nate Cole, and Jeff Sposetti.
Bugs: AMBARI-8562
https://issues.apache.org/jira/browse/AMBARI-8562
Repository: ambari
Description
-------
Ambari agent should restart with -v option if previous ambari-agent process was run with -v option. Accordinly this option we shoul show/hide traceback.
How it will work:
1) ambari-agent always have been restarted even if ambari-agent didn't started before, so we should restart ambari-agent with '-v' option if previous process of ambari-agent was started with '-v'
2) If '-v' option is not defined in command line all exceptions with tracebacks, which rised while setup of ambari-agent, will be showed in output, othewise only error messages will be showed in output.
Diffs
-----
ambari-server/src/main/python/os_check_type.py f890504
ambari-server/src/main/python/setupAgent.py ede83c5
ambari-server/src/test/python/TestOSCheck.py 20b8890
ambari-server/src/test/python/TestSetupAgent.py 8293fd0
Diff: https://reviews.apache.org/r/28512/diff/
Testing
-------
tests passed
Thanks,
Dmytro Sen