You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2022/09/20 18:08:04 UTC
[GitHub] [druid] benkrug opened a new pull request, #13131: Update clean-metadata-store.md
benkrug opened a new pull request, #13131:
URL: https://github.com/apache/druid/pull/13131
Added details about what's cleaned up in the indexer task log case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] vtlim commented on a diff in pull request #13131: Update clean-metadata-store.md
Posted by "vtlim (via GitHub)" <gi...@apache.org>.
vtlim commented on code in PR #13131:
URL: https://github.com/apache/druid/pull/13131#discussion_r1091324784
##########
docs/operations/clean-metadata-store.md:
##########
@@ -143,7 +143,9 @@ Datasource cleanup uses the following configuration:
### Indexer task logs
-You can configure the Overlord to delete indexer task log metadata and the indexer task logs from local disk or from cloud storage.
+You can configure the Overlord to periodically delete indexer task logs and associated metadata. During cleanup, the Overlord removes the following:
+* Indexer task logs from local disk or cloud storage.
+* Indexer task log metadata from the `druid_tasks` and `druid_taskLog` tables in [metadata storage](../configuration/index.md#metadata-storage). Previous versions of Druid stored task logs in the metadata database table `druid_tasklogs`. However, this table is no longer used in the current version, and the table is always empty.
Review Comment:
```suggestion
* Indexer task log metadata from the `druid_tasks` and `druid_tasklogs` tables in [metadata storage](../configuration/index.md#metadata-storage). Previous versions of Druid stored task logs in the metadata database table `druid_tasklogs`. However, this table is no longer used in the current version, and the table is always empty.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] vtlim commented on a diff in pull request #13131: Update clean-metadata-store.md
Posted by "vtlim (via GitHub)" <gi...@apache.org>.
vtlim commented on code in PR #13131:
URL: https://github.com/apache/druid/pull/13131#discussion_r1091329453
##########
docs/operations/clean-metadata-store.md:
##########
@@ -143,7 +143,9 @@ Datasource cleanup uses the following configuration:
### Indexer task logs
-You can configure the Overlord to delete indexer task log metadata and the indexer task logs from local disk or from cloud storage.
+You can configure the Overlord to periodically delete indexer task logs and associated metadata. During cleanup, the Overlord removes the following:
+* Indexer task logs from deep storage.
+* Indexer task log metadata from the `druid_tasks` and `druid_tasklogs` tables in [metadata storage](../configuration/index.md#metadata-storage). Previous versions of Druid stored task logs in the metadata database table `druid_tasklogs`. However, this table is no longer used in the current version, and the table is always empty.
Review Comment:
```suggestion
* Indexer task log metadata from the `druid_tasks` and `druid_tasklogs` tables in [metadata storage](../configuration/index.md#metadata-storage). Druid no longer uses the `druid_tasklogs` table, and the table is always empty.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] vtlim commented on a diff in pull request #13131: Update clean-metadata-store.md
Posted by GitBox <gi...@apache.org>.
vtlim commented on code in PR #13131:
URL: https://github.com/apache/druid/pull/13131#discussion_r980534414
##########
docs/operations/clean-metadata-store.md:
##########
@@ -143,7 +143,7 @@ Datasource cleanup uses the following configuration:
### Indexer task logs
-You can configure the Overlord to delete indexer task log metadata and the indexer task logs from local disk or from cloud storage.
+You can configure the Overlord to delete indexer task log metadata and the indexer task logs from local disk or from cloud storage. The cleanup includes the `druid_tasks` and `druid_tasklogs` tables in the metadata database, and the task logs in deep storage. (Note that `druid_tasklogs` is no longer used and will already be empty, unless the druid version is older.)
Review Comment:
```suggestion
You can configure the Overlord to delete indexer task log metadata and the indexer task logs from local disk or from cloud storage.
During cleanup, the Overlord removes the `druid_tasks` and `druid_tasklogs` tables from [metadata storage](../configuration/index.md#metadata-storage) and removes task logs from deep storage.
Note that `druid_tasklogs` is no longer used and will already be empty, unless the Druid version is older.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] vtlim commented on a diff in pull request #13131: Update clean-metadata-store.md
Posted by "vtlim (via GitHub)" <gi...@apache.org>.
vtlim commented on code in PR #13131:
URL: https://github.com/apache/druid/pull/13131#discussion_r980534414
##########
docs/operations/clean-metadata-store.md:
##########
@@ -143,7 +143,7 @@ Datasource cleanup uses the following configuration:
### Indexer task logs
-You can configure the Overlord to delete indexer task log metadata and the indexer task logs from local disk or from cloud storage.
+You can configure the Overlord to delete indexer task log metadata and the indexer task logs from local disk or from cloud storage. The cleanup includes the `druid_tasks` and `druid_tasklogs` tables in the metadata database, and the task logs in deep storage. (Note that `druid_tasklogs` is no longer used and will already be empty, unless the druid version is older.)
Review Comment:
```suggestion
You can configure the Overlord to periodically delete indexer task logs and associated metadata. During cleanup, the Overlord removes the following:
* Indexer task logs from local disk or cloud storage.
* Indexer task log metadata from the `druid_tasks` and `druid_taskLog` tables in [metadata storage](../configuration/index.md#metadata-storage). Note that Druid no longer uses the `druid_tasklogs` table, which should be empty in new versions of Druid.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] vtlim commented on a diff in pull request #13131: Update clean-metadata-store.md
Posted by GitBox <gi...@apache.org>.
vtlim commented on code in PR #13131:
URL: https://github.com/apache/druid/pull/13131#discussion_r980534414
##########
docs/operations/clean-metadata-store.md:
##########
@@ -143,7 +143,7 @@ Datasource cleanup uses the following configuration:
### Indexer task logs
-You can configure the Overlord to delete indexer task log metadata and the indexer task logs from local disk or from cloud storage.
+You can configure the Overlord to delete indexer task log metadata and the indexer task logs from local disk or from cloud storage. The cleanup includes the `druid_tasks` and `druid_tasklogs` tables in the metadata database, and the task logs in deep storage. (Note that `druid_tasklogs` is no longer used and will already be empty, unless the druid version is older.)
Review Comment:
```suggestion
You can configure the Overlord to delete indexer task log metadata and the indexer task logs from local disk or from cloud storage.
During cleanup, the Overlord removes the `druid_tasks` and `druid_tasklogs` tables from [metadata storage](../configuration/index.md#metadata-storage) and removes task logs from deep storage.
Note that `druid_tasklogs` is no longer used and will already be empty, unless the druid version is older.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] paul-rogers commented on a diff in pull request #13131: Update clean-metadata-store.md
Posted by GitBox <gi...@apache.org>.
paul-rogers commented on code in PR #13131:
URL: https://github.com/apache/druid/pull/13131#discussion_r992900167
##########
docs/operations/clean-metadata-store.md:
##########
@@ -143,7 +143,7 @@ Datasource cleanup uses the following configuration:
### Indexer task logs
-You can configure the Overlord to delete indexer task log metadata and the indexer task logs from local disk or from cloud storage.
+You can configure the Overlord to delete indexer task log metadata and the indexer task logs from local disk or from cloud storage. The cleanup includes the `druid_tasks` and `druid_tasklogs` tables in the metadata database, and the task logs in deep storage. (Note that `druid_tasklogs` is no longer used and will already be empty, unless the druid version is older.)
Review Comment:
Is this cleanup absolute? That is, it deletes everything? Or, only items older than some expiration age? (If everything, then there is a feature request to have that cutoff.)
When configuring, does the cleanup occur on a schedule? After every task?
I'd be very surprised if the cleanup actually "removes the `druid_tasks` and `druid_tasklogs` tables". This seems extreme, and introduces race conditions. Does it actually "drop all records in the `druid_tasks` and `druid_tasklogs` tables"?
If we do the brute-force, drop all info approach, then suggestion:
> You can configure the Overlord to delete information for all indexer tasks which have either completed or failed. During cleanup, the Overlord drops all records from the `druid_tasks` and `druid_tasklogs` tables in the metadata database. Overlord also removes all task logs from deep storage.
What it would be great if we could say:
> You can configure the Overlord to periodically expire (delete) indexer task information. Overlord will delete tasks that have either completed or failed if those tasks are older than the expiration period. During cleanup, the Overlord drops expired records from the `druid_tasks` and `druid_tasklogs` tables in the metadata database. Overlord also removes expired task logs from deep storage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] vtlim commented on a diff in pull request #13131: Update clean-metadata-store.md
Posted by GitBox <gi...@apache.org>.
vtlim commented on code in PR #13131:
URL: https://github.com/apache/druid/pull/13131#discussion_r980535420
##########
docs/operations/clean-metadata-store.md:
##########
@@ -143,7 +143,7 @@ Datasource cleanup uses the following configuration:
### Indexer task logs
-You can configure the Overlord to delete indexer task log metadata and the indexer task logs from local disk or from cloud storage.
+You can configure the Overlord to delete indexer task log metadata and the indexer task logs from local disk or from cloud storage. The cleanup includes the `druid_tasks` and `druid_tasklogs` tables in the metadata database, and the task logs in deep storage. (Note that `druid_tasklogs` is no longer used and will already be empty, unless the druid version is older.)
Review Comment:
Two follow up questions:
1. Do you know what older version uses `druid_tasklogs`? Wondering if we can say something like "unless the Druid version is XX or older."
2. Should the table be called `druid_taskLog`? That's what's listed in the configuration table: https://druid.apache.org/docs/latest/configuration/index.html#metadata-storage
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] vtlim commented on a diff in pull request #13131: Update clean-metadata-store.md
Posted by "vtlim (via GitHub)" <gi...@apache.org>.
vtlim commented on code in PR #13131:
URL: https://github.com/apache/druid/pull/13131#discussion_r1091324784
##########
docs/operations/clean-metadata-store.md:
##########
@@ -143,7 +143,9 @@ Datasource cleanup uses the following configuration:
### Indexer task logs
-You can configure the Overlord to delete indexer task log metadata and the indexer task logs from local disk or from cloud storage.
+You can configure the Overlord to periodically delete indexer task logs and associated metadata. During cleanup, the Overlord removes the following:
+* Indexer task logs from local disk or cloud storage.
+* Indexer task log metadata from the `druid_tasks` and `druid_taskLog` tables in [metadata storage](../configuration/index.md#metadata-storage). Previous versions of Druid stored task logs in the metadata database table `druid_tasklogs`. However, this table is no longer used in the current version, and the table is always empty.
Review Comment:
```suggestion
* Indexer task log metadata from the `druid_tasks` and `druid_tasklogs` tables in [metadata storage](../configuration/index.md#metadata-storage). Previous versions of Druid stored task logs in the metadata database table `druid_tasklogs`. However, this table is no longer used in the current version, and the table is always empty.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] paul-rogers commented on a diff in pull request #13131: Update clean-metadata-store.md
Posted by "paul-rogers (via GitHub)" <gi...@apache.org>.
paul-rogers commented on code in PR #13131:
URL: https://github.com/apache/druid/pull/13131#discussion_r1091305140
##########
docs/operations/clean-metadata-store.md:
##########
@@ -143,7 +143,7 @@ Datasource cleanup uses the following configuration:
### Indexer task logs
-You can configure the Overlord to delete indexer task log metadata and the indexer task logs from local disk or from cloud storage.
+You can configure the Overlord to delete indexer task log metadata and the indexer task logs from local disk or from cloud storage. The cleanup includes the `druid_tasks` and `druid_tasklogs` tables in the metadata database, and the task logs in deep storage. (Note that `druid_tasklogs` is no longer used and will already be empty, unless the druid version is older.)
Review Comment:
Looks good. The following is a bit unclear:
> (Note that `druid_tasklogs` is no longer used and will already be empty, unless the druid version is older.)
Maybe:
> The cleanup includes the `druid_tasks` table in the metadata database, and the task logs in deep storage. In previous versions of Druid task logs were stored in the the metadata database table `druid_tasklogs`. However, this table is no longer used in the current version and the table is always empty.
Also, I like your "periodically" wording so we know that that this isn't one shot:
> You can configure the Overlord to delete indexer logs periodically. Indexer logs include ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] vtlim commented on a diff in pull request #13131: Update clean-metadata-store.md
Posted by "vtlim (via GitHub)" <gi...@apache.org>.
vtlim commented on code in PR #13131:
URL: https://github.com/apache/druid/pull/13131#discussion_r1091327963
##########
docs/operations/clean-metadata-store.md:
##########
@@ -143,7 +143,9 @@ Datasource cleanup uses the following configuration:
### Indexer task logs
-You can configure the Overlord to delete indexer task log metadata and the indexer task logs from local disk or from cloud storage.
+You can configure the Overlord to periodically delete indexer task logs and associated metadata. During cleanup, the Overlord removes the following:
+* Indexer task logs from local disk or cloud storage.
Review Comment:
```suggestion
* Indexer task logs from deep storage.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] vtlim merged pull request #13131: Update clean-metadata-store.md
Posted by "vtlim (via GitHub)" <gi...@apache.org>.
vtlim merged PR #13131:
URL: https://github.com/apache/druid/pull/13131
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] vtlim commented on a diff in pull request #13131: Update clean-metadata-store.md
Posted by "vtlim (via GitHub)" <gi...@apache.org>.
vtlim commented on code in PR #13131:
URL: https://github.com/apache/druid/pull/13131#discussion_r1091330107
##########
docs/operations/clean-metadata-store.md:
##########
@@ -143,7 +143,9 @@ Datasource cleanup uses the following configuration:
### Indexer task logs
-You can configure the Overlord to delete indexer task log metadata and the indexer task logs from local disk or from cloud storage.
+You can configure the Overlord to periodically delete indexer task logs and associated metadata. During cleanup, the Overlord removes the following:
+* Indexer task logs from deep storage.
+* Indexer task log metadata from the `druid_tasks` and `druid_tasklogs` tables in [metadata storage](../configuration/index.md#metadata-storage). Druid no longer uses the `druid_tasklogs` table, and the table is always empty.
Set these properties in the `overlord/runtime.properties` file.
Review Comment:
```suggestion
To configure cleanup of task logs by the Overlord, set the following properties in the `overlord/runtime.properties` file.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] vtlim commented on a diff in pull request #13131: Update clean-metadata-store.md
Posted by "vtlim (via GitHub)" <gi...@apache.org>.
vtlim commented on code in PR #13131:
URL: https://github.com/apache/druid/pull/13131#discussion_r1091329453
##########
docs/operations/clean-metadata-store.md:
##########
@@ -143,7 +143,9 @@ Datasource cleanup uses the following configuration:
### Indexer task logs
-You can configure the Overlord to delete indexer task log metadata and the indexer task logs from local disk or from cloud storage.
+You can configure the Overlord to periodically delete indexer task logs and associated metadata. During cleanup, the Overlord removes the following:
+* Indexer task logs from deep storage.
+* Indexer task log metadata from the `druid_tasks` and `druid_tasklogs` tables in [metadata storage](../configuration/index.md#metadata-storage). Previous versions of Druid stored task logs in the metadata database table `druid_tasklogs`. However, this table is no longer used in the current version, and the table is always empty.
Review Comment:
```suggestion
* Indexer task log metadata from the `druid_tasks` and `druid_tasklogs` tables in [metadata storage](../configuration/index.md#metadata-storage). Druid no longer uses the `druid_tasklogs` table, and the table is always empty.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] vtlim commented on a diff in pull request #13131: Update clean-metadata-store.md
Posted by "vtlim (via GitHub)" <gi...@apache.org>.
vtlim commented on code in PR #13131:
URL: https://github.com/apache/druid/pull/13131#discussion_r1091300330
##########
docs/operations/clean-metadata-store.md:
##########
@@ -143,7 +143,7 @@ Datasource cleanup uses the following configuration:
### Indexer task logs
-You can configure the Overlord to delete indexer task log metadata and the indexer task logs from local disk or from cloud storage.
+You can configure the Overlord to delete indexer task log metadata and the indexer task logs from local disk or from cloud storage. The cleanup includes the `druid_tasks` and `druid_tasklogs` tables in the metadata database, and the task logs in deep storage. (Note that `druid_tasklogs` is no longer used and will already be empty, unless the druid version is older.)
Review Comment:
@paul-rogers The cleanup is based on a schedule and is configured by a few different properties. I updated my suggestion based on your recommendation. The properties to configure the cleanup are already in this section in the lines below (https://druid.apache.org/docs/latest/operations/clean-metadata-store.html#indexer-task-logs)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] vtlim commented on a diff in pull request #13131: Update clean-metadata-store.md
Posted by "vtlim (via GitHub)" <gi...@apache.org>.
vtlim commented on code in PR #13131:
URL: https://github.com/apache/druid/pull/13131#discussion_r980534414
##########
docs/operations/clean-metadata-store.md:
##########
@@ -143,7 +143,7 @@ Datasource cleanup uses the following configuration:
### Indexer task logs
-You can configure the Overlord to delete indexer task log metadata and the indexer task logs from local disk or from cloud storage.
+You can configure the Overlord to delete indexer task log metadata and the indexer task logs from local disk or from cloud storage. The cleanup includes the `druid_tasks` and `druid_tasklogs` tables in the metadata database, and the task logs in deep storage. (Note that `druid_tasklogs` is no longer used and will already be empty, unless the druid version is older.)
Review Comment:
```suggestion
You can configure the Overlord to periodically delete indexer task logs and associated metadata. During cleanup, the Overlord removes the following:
* Indexer task logs from local disk or cloud storage.
* Indexer task log metadata from the `druid_tasks` and `druid_taskLog` tables in [metadata storage](../configuration/index.md#metadata-storage). Previous versions of Druid stored task logs in the metadata database table `druid_tasklogs`. However, this table is no longer used in the current version, and the table is always empty.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] vtlim commented on a diff in pull request #13131: Update clean-metadata-store.md
Posted by "vtlim (via GitHub)" <gi...@apache.org>.
vtlim commented on code in PR #13131:
URL: https://github.com/apache/druid/pull/13131#discussion_r1091321246
##########
docs/operations/clean-metadata-store.md:
##########
@@ -143,7 +143,7 @@ Datasource cleanup uses the following configuration:
### Indexer task logs
-You can configure the Overlord to delete indexer task log metadata and the indexer task logs from local disk or from cloud storage.
+You can configure the Overlord to delete indexer task log metadata and the indexer task logs from local disk or from cloud storage. The cleanup includes the `druid_tasks` and `druid_tasklogs` tables in the metadata database, and the task logs in deep storage. (Note that `druid_tasklogs` is no longer used and will already be empty, unless the druid version is older.)
Review Comment:
Updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org