Re: [PR] CASSPYTHON-18: removed obsolete check for python version > 3.7+ [cassandra-python-driver]

["absurdfarce (via GitHub)" <gi...@apache.org>]

absurdfarce commented on code in PR #1290:
URL: https://github.com/apache/cassandra-python-driver/pull/1290#discussion_r3174273914


##########
tests/unit/test_row_factories.py:
##########
@@ -49,37 +45,16 @@ class TestNamedTupleFactory(TestCase):
 
     def test_creation_warning_on_long_column_list(self):
         """
-        Reproduces the failure described in PYTHON-893
-
-        @since 3.15
-        @jira_ticket PYTHON-893
-        @expected_result creation fails on Python > 3 and < 3.7
-
-        @test_category row_factory
+        Test for a regression in PYTHON-893.  Shouldn't be an issue with currently
+        supported versions since the underlying issue was fixed in Python 3.7

Review Comment:
   The underlying problem is fixed in Python 3.7 (see [PYTHON-893](https://datastax-oss.atlassian.net/browse/PYTHON-893) for more on that point) so we should no longer have any case in which NAMEDTUPLE_CREATION_BUG eval's to true.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org