You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Aaron Wood via Review Board <no...@reviews.apache.org> on 2017/05/22 16:52:14 UTC
Re: Review Request 59413: Fix bytes.hpp constexpr compilation failure
with GCC 7.1.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59413/
-----------------------------------------------------------
(Updated May 22, 2017, 4:52 p.m.)
Review request for mesos, Benjamin Bannier, James Peach, Michael Park, and Neil Conway.
Changes
-------
Rework patch to only target bytes.hpp.
Summary (updated)
-----------------
Fix bytes.hpp constexpr compilation failure with GCC 7.1.
Bugs: MESOS-7520
https://issues.apache.org/jira/browse/MESOS-7520
Repository: mesos
Description (updated)
-------
Many of the `constexpr` variables fail to compile with errors such as `error: 'Megabytes(32).Megabytes::<anonymous>' is not a constant expression because it refers to an incompletely initialized variable`. https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80829
This patch changes around the `Bytes` class a bit by getting rid of the small classes that extend `Bytes`.
Diffs (updated)
-----
3rdparty/stout/include/stout/bytes.hpp 98223db50
Diff: https://reviews.apache.org/r/59413/diff/4/
Changes: https://reviews.apache.org/r/59413/diff/3-4/
Testing
-------
`./bootstrap && mkdir build && cd build && ../configure --disable-python --disable-java --disable-optimize --disable-hardening && make -j$(nproc)`
Thanks,
Aaron Wood
Re: Review Request 59413: Fix bytes.hpp constexpr compilation failure
with GCC 7.1.
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59413/#review176027
-----------------------------------------------------------
Fix it, then Ship it!
3rdparty/stout/include/stout/bytes.hpp
Lines 125 (patched)
<https://reviews.apache.org/r/59413/#comment249362>
Unfortunately these definititons break the line length limit. You'll have to do:
```
inline constexpr Bytes Kilobytes(uint64_t value)
{
return Bytes(value, Bytes::KILOBYTES);
}
```
- James Peach
On May 22, 2017, 4:56 p.m., Aaron Wood wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59413/
> -----------------------------------------------------------
>
> (Updated May 22, 2017, 4:56 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, James Peach, Michael Park, and Neil Conway.
>
>
> Bugs: MESOS-7520
> https://issues.apache.org/jira/browse/MESOS-7520
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Many of the `constexpr` variables fail to compile with errors such as `error: 'Megabytes(32).Megabytes::<anonymous>' is not a constant expression because it refers to an incompletely initialized variable`. https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80829
>
> This patch changes around the `Bytes` class a bit by getting rid of the small classes that extend `Bytes`.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/bytes.hpp 98223db50
>
>
> Diff: https://reviews.apache.org/r/59413/diff/4/
>
>
> Testing
> -------
>
> `./bootstrap && mkdir build && cd build && ../configure --disable-python --disable-java --disable-optimize --disable-hardening && make -j$(nproc)`
>
>
> Thanks,
>
> Aaron Wood
>
>
Re: Review Request 59413: Fix bytes.hpp constexpr compilation failure
with GCC 7.1.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59413/#review178318
-----------------------------------------------------------
Fix it, then Ship it!
3rdparty/stout/include/stout/bytes.hpp
Line 122 (original), 121 (patched)
<https://reviews.apache.org/r/59413/#comment252201>
2 lines apart.
- Jie Yu
On May 25, 2017, 6:13 p.m., Aaron Wood wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59413/
> -----------------------------------------------------------
>
> (Updated May 25, 2017, 6:13 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, James Peach, Michael Park, and Neil Conway.
>
>
> Bugs: MESOS-7520
> https://issues.apache.org/jira/browse/MESOS-7520
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Many of the `constexpr` variables fail to compile with errors such as `error: 'Megabytes(32).Megabytes::<anonymous>' is not a constant expression because it refers to an incompletely initialized variable`. https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80829
>
> This patch changes around the `Bytes` class a bit by getting rid of the small classes that extend `Bytes`.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/bytes.hpp 98223db50
>
>
> Diff: https://reviews.apache.org/r/59413/diff/5/
>
>
> Testing
> -------
>
> `./bootstrap && mkdir build && cd build && ../configure --disable-python --disable-java --disable-optimize --disable-hardening && make -j$(nproc) && make check -j$(nproc)`
>
>
> Thanks,
>
> Aaron Wood
>
>
Re: Review Request 59413: Fix bytes.hpp constexpr compilation failure
with GCC 7.1.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59413/#review176162
-----------------------------------------------------------
Patch looks great!
Reviews applied: [59454, 59413]
Passed command: support\windows-build.bat
- Mesos Reviewbot Windows
On May 25, 2017, 6:13 p.m., Aaron Wood wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59413/
> -----------------------------------------------------------
>
> (Updated May 25, 2017, 6:13 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, James Peach, Michael Park, and Neil Conway.
>
>
> Bugs: MESOS-7520
> https://issues.apache.org/jira/browse/MESOS-7520
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Many of the `constexpr` variables fail to compile with errors such as `error: 'Megabytes(32).Megabytes::<anonymous>' is not a constant expression because it refers to an incompletely initialized variable`. https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80829
>
> This patch changes around the `Bytes` class a bit by getting rid of the small classes that extend `Bytes`.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/bytes.hpp 98223db50
>
>
> Diff: https://reviews.apache.org/r/59413/diff/5/
>
>
> Testing
> -------
>
> `./bootstrap && mkdir build && cd build && ../configure --disable-python --disable-java --disable-optimize --disable-hardening && make -j$(nproc) && make check -j$(nproc)`
>
>
> Thanks,
>
> Aaron Wood
>
>
Re: Review Request 59413: Fix bytes.hpp constexpr compilation failure
with GCC 7.1.
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59413/#review176159
-----------------------------------------------------------
Ship it!
Ship It!
- James Peach
On May 25, 2017, 6:13 p.m., Aaron Wood wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59413/
> -----------------------------------------------------------
>
> (Updated May 25, 2017, 6:13 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, James Peach, Michael Park, and Neil Conway.
>
>
> Bugs: MESOS-7520
> https://issues.apache.org/jira/browse/MESOS-7520
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Many of the `constexpr` variables fail to compile with errors such as `error: 'Megabytes(32).Megabytes::<anonymous>' is not a constant expression because it refers to an incompletely initialized variable`. https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80829
>
> This patch changes around the `Bytes` class a bit by getting rid of the small classes that extend `Bytes`.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/bytes.hpp 98223db50
>
>
> Diff: https://reviews.apache.org/r/59413/diff/5/
>
>
> Testing
> -------
>
> `./bootstrap && mkdir build && cd build && ../configure --disable-python --disable-java --disable-optimize --disable-hardening && make -j$(nproc) && make check -j$(nproc)`
>
>
> Thanks,
>
> Aaron Wood
>
>
Re: Review Request 59413: Fix bytes.hpp constexpr compilation failure
with GCC 7.1.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59413/#review176178
-----------------------------------------------------------
Patch looks great!
Reviews applied: [59454, 59413]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On May 25, 2017, 11:13 a.m., Aaron Wood wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59413/
> -----------------------------------------------------------
>
> (Updated May 25, 2017, 11:13 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, James Peach, Michael Park, and Neil Conway.
>
>
> Bugs: MESOS-7520
> https://issues.apache.org/jira/browse/MESOS-7520
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Many of the `constexpr` variables fail to compile with errors such as `error: 'Megabytes(32).Megabytes::<anonymous>' is not a constant expression because it refers to an incompletely initialized variable`. https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80829
>
> This patch changes around the `Bytes` class a bit by getting rid of the small classes that extend `Bytes`.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/bytes.hpp 98223db50
>
>
> Diff: https://reviews.apache.org/r/59413/diff/5/
>
>
> Testing
> -------
>
> `./bootstrap && mkdir build && cd build && ../configure --disable-python --disable-java --disable-optimize --disable-hardening && make -j$(nproc) && make check -j$(nproc)`
>
>
> Thanks,
>
> Aaron Wood
>
>
Re: Review Request 59413: Fix bytes.hpp constexpr compilation failure
with GCC 7.1.
Posted by Aaron Wood via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59413/
-----------------------------------------------------------
(Updated May 25, 2017, 6:13 p.m.)
Review request for mesos, Benjamin Bannier, James Peach, Michael Park, and Neil Conway.
Bugs: MESOS-7520
https://issues.apache.org/jira/browse/MESOS-7520
Repository: mesos
Description
-------
Many of the `constexpr` variables fail to compile with errors such as `error: 'Megabytes(32).Megabytes::<anonymous>' is not a constant expression because it refers to an incompletely initialized variable`. https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80829
This patch changes around the `Bytes` class a bit by getting rid of the small classes that extend `Bytes`.
Diffs
-----
3rdparty/stout/include/stout/bytes.hpp 98223db50
Diff: https://reviews.apache.org/r/59413/diff/5/
Testing (updated)
-------
`./bootstrap && mkdir build && cd build && ../configure --disable-python --disable-java --disable-optimize --disable-hardening && make -j$(nproc) && make check -j$(nproc)`
Thanks,
Aaron Wood
Re: Review Request 59413: Fix bytes.hpp constexpr compilation failure
with GCC 7.1.
Posted by Aaron Wood via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59413/
-----------------------------------------------------------
(Updated May 25, 2017, 4:42 p.m.)
Review request for mesos, Benjamin Bannier, James Peach, Michael Park, and Neil Conway.
Changes
-------
Fixed formatting.
Bugs: MESOS-7520
https://issues.apache.org/jira/browse/MESOS-7520
Repository: mesos
Description
-------
Many of the `constexpr` variables fail to compile with errors such as `error: 'Megabytes(32).Megabytes::<anonymous>' is not a constant expression because it refers to an incompletely initialized variable`. https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80829
This patch changes around the `Bytes` class a bit by getting rid of the small classes that extend `Bytes`.
Diffs (updated)
-----
3rdparty/stout/include/stout/bytes.hpp 98223db50
Diff: https://reviews.apache.org/r/59413/diff/5/
Changes: https://reviews.apache.org/r/59413/diff/4-5/
Testing
-------
`./bootstrap && mkdir build && cd build && ../configure --disable-python --disable-java --disable-optimize --disable-hardening && make -j$(nproc)`
Thanks,
Aaron Wood
Re: Review Request 59413: Fix bytes.hpp constexpr compilation failure
with GCC 7.1.
Posted by Aaron Wood via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59413/
-----------------------------------------------------------
(Updated May 22, 2017, 4:56 p.m.)
Review request for mesos, Benjamin Bannier, James Peach, Michael Park, and Neil Conway.
Bugs: MESOS-7520
https://issues.apache.org/jira/browse/MESOS-7520
Repository: mesos
Description
-------
Many of the `constexpr` variables fail to compile with errors such as `error: 'Megabytes(32).Megabytes::<anonymous>' is not a constant expression because it refers to an incompletely initialized variable`. https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80829
This patch changes around the `Bytes` class a bit by getting rid of the small classes that extend `Bytes`.
Diffs
-----
3rdparty/stout/include/stout/bytes.hpp 98223db50
Diff: https://reviews.apache.org/r/59413/diff/4/
Testing
-------
`./bootstrap && mkdir build && cd build && ../configure --disable-python --disable-java --disable-optimize --disable-hardening && make -j$(nproc)`
Thanks,
Aaron Wood