[jira] Commented: (HADOOP-4236) JobTracker.killJob() fails to kill a job if the job is not yet initialized

["Vinod K V (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-4236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12637362#action_12637362 ] 

Vinod K V commented on HADOOP-4236:
-----------------------------------

This patch should also have a fix for JobInProgress.kill() so that calling this on an uninitialized job kills the job completely.

At present, calling JIP.kill() will just mark the job for killing, but job is truly not killed completely. A job is completely killed only when JIP.terminateJob()) is called on it, which does things like logging to JobHistory and marking JobStatus as killed. Currently, this method isn't called until a clean-up task is scheduled and runs to completion, but for uninitialized jobs there are no clean-up tasks and so job-kill remains incomplete for ever.

> JobTracker.killJob() fails to kill a job if the job is not yet initialized
> --------------------------------------------------------------------------
>
>                 Key: HADOOP-4236
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4236
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: mapred
>    Affects Versions: 0.19.0
>            Reporter: Amar Kamat
>            Assignee: Sharad Agarwal
>            Priority: Blocker
>             Fix For: 0.19.0
>
>
> HADOOP-3864 made the following changes to {{JobTracker.killJob()}}
> {code}
>    public synchronized void killJob(JobID jobid) {
>      JobInProgress job = jobs.get(jobid);
> -    job.kill();
> +    if (job.inited()) {
> +      job.kill();
> +    }
>    }
> {code}
> This is a bug as a job will not get killed if its not yet initialized.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.