You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2020/04/27 19:22:19 UTC

[GitHub] [nifi] alopresto commented on a change in pull request #4236: NIFI-7389: Makes Missable heartbeat counts configurable

alopresto commented on a change in pull request #4236:
URL: https://github.com/apache/nifi/pull/4236#discussion_r416085004



##########
File path: nifi-commons/nifi-properties/src/main/java/org/apache/nifi/util/NiFiProperties.java
##########
@@ -203,6 +203,7 @@
 
     // cluster common properties
     public static final String CLUSTER_PROTOCOL_HEARTBEAT_INTERVAL = "nifi.cluster.protocol.heartbeat.interval";
+    public static final String CLUSTER_PROTOCOL_HEARTBEAT_MAX = "nifi.cluster.protocol.heartbeat.max";

Review comment:
       I think the property key should contain `missable` to indicate what the maximum _is_. Something like `CLUSTER_PROTOCOL_HEARTBEAT_MISSABLE_MAX = "nifi.cluster.protocol.heartbeat.missable.max";`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org