You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2019/12/19 07:16:56 UTC

[GitHub] [incubator-mxnet] leezu opened a new pull request #17121: Include 3rdparty/jemalloc (Fix for Ubuntu 18.10+, Debian Stable, etc.)

leezu opened a new pull request #17121: Include 3rdparty/jemalloc (Fix for Ubuntu 18.10+, Debian Stable, etc.)
URL: https://github.com/apache/incubator-mxnet/pull/17121
 
 
   ## Description ##
   As of jemalloc 5, jemalloc default build can not be used in libraries that `dlopen`ed. However, `libmxnet.so` is `dlopen`ed by Python (ctypes). We can thus not link to system `libjemalloc.so` but must rather link to a `libjemalloc` compiled as part of our build process.
   
   jemalloc 5 is distributed as part of Ubuntu 18.10 and higher, as well as Debian Stable.
   Users on these systems will be unable to compile MXNet with `USE_JEMALLOC=ON` (which is the default).
   
   This PR contains the necessary changes.
   
   ## Checklist ##
   ### Essentials ###
   Please feel free to remove inapplicable items for your PR.
   - [X] Changes are complete (i.e. I finished coding on this PR)
   - [X] All changes have test coverage:
   - Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
   - Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
   - Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
   - [X] Code is well-documented: 
   - For user-facing API changes, API doc string has been updated. 
   - For new C++ functions in header files, their functionalities and arguments are documented. 
   - For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
   - Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
   - [X] To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
   
   ### Changes ###
   - [X] Include 3rdparty/jemalloc
   
   ## Comments ##
   - We include a patched version of `jemalloc` that adds CMake support. Once the patch is mainlined, we can switch to the official repo. The patch is currently hosted at https://github.com/leezu/jemalloc/tree/add/cmake-2019. All credits go to @mattsta (see https://github.com/jemalloc/jemalloc/issues/303)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-mxnet] leezu commented on issue #17121: Include 3rdparty/jemalloc (Fix for Ubuntu 18.10+, Debian Stable, etc.)

Posted by GitBox <gi...@apache.org>.
leezu commented on issue #17121: Include 3rdparty/jemalloc (Fix for Ubuntu 18.10+, Debian Stable, etc.)
URL: https://github.com/apache/incubator-mxnet/pull/17121#issuecomment-576464949
 
 
   Close this until stable upstream. See https://github.com/jemalloc/jemalloc/issues/303.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-mxnet] leezu closed pull request #17121: Include 3rdparty/jemalloc (Fix for Ubuntu 18.10+, Debian Stable, etc.)

Posted by GitBox <gi...@apache.org>.
leezu closed pull request #17121: Include 3rdparty/jemalloc (Fix for Ubuntu 18.10+, Debian Stable, etc.)
URL: https://github.com/apache/incubator-mxnet/pull/17121
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-mxnet] leezu edited a comment on issue #17121: Include 3rdparty/jemalloc (Fix for Ubuntu 18.10+, Debian Stable, etc.)

Posted by GitBox <gi...@apache.org>.
leezu edited a comment on issue #17121: Include 3rdparty/jemalloc (Fix for Ubuntu 18.10+, Debian Stable, etc.)
URL: https://github.com/apache/incubator-mxnet/pull/17121#issuecomment-576464949
 
 
   Close this until stable upstream. See https://github.com/jemalloc/jemalloc/issues/303.
   
   https://github.com/apache/incubator-mxnet/pull/17324 disables jemalloc by default until then.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services