You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@opennlp.apache.org by thygesen <gi...@git.apache.org> on 2017/05/03 18:58:15 UTC

[GitHub] opennlp pull request #193: OPENNLP-1037: OpenNLP build fails if only the eva...

GitHub user thygesen opened a pull request:

    https://github.com/apache/opennlp/pull/193

    OPENNLP-1037: OpenNLP build fails if only the eval tests are run

    **Modified the surefire configuration:**
    
    "mvn test" will run all tests except those excluded in root pom (*see note)
    "mvn eval" will run all tests and the "SourceForgeModelEval" test.
    
    You can also run specific tests. e.g. "mvn test -DOPENNLP_DATA_DIR=/home/blue/opennlp-data-dir -Dtest=OntoNotes4Pos*"
    
    **Implementations Notes:**
    (Root pom.xml)
    Added  <failIfNoSpecifiedTests>false</failIfNoSpecifiedTests> to global surefire configuration to prevent failure if running specific tests from root folder e.g. mvn test -Dtest=Chunker*
    
    Added profile "eval" which automatically is enabled if OPENNLP_DATA_DIR is defined. e.g. mvn test -DOPENNLP_DATA_DIR=/user/eval-data 
    
    Eval profile: Explicit included tests: "**/*Test.java" and the eval test "**/SourceForgeModelEval.java" which does not follow the normal name pattern and therefore needs to be explicit defined.
    forkCount and failIdNoSpecifiedTests are same as global configuration.
    
    The following tests are disabled. But I cannot figure out why. Can anybody recall why they were disabled?
    /src/test/java/opennlp/tools/stemmer/PorterStemmerTest.java
    /src/test/java/opennlp/tools/stemmer/SnowballStemmerTest.java

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/thygesen/opennlp opennlp-1037

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/opennlp/pull/193.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #193
    
----
commit d44fe15b1bc46639d7ba6b3eb58d8441985ae345
Author: Peter Thygesen <th...@apache.org>
Date:   2017-05-03T18:55:07Z

    OPENNLP-1037: OpenNLP build fails if only the eval tests are run

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] opennlp pull request #193: OPENNLP-1037: OpenNLP build fails if only the eva...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/opennlp/pull/193


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---