You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2016/08/09 20:49:50 UTC
[kudu-CR] [client][gutil] introduced ATTRIBUTE DEPRECATED
Alexey Serbin has uploaded a new change for review.
http://gerrit.cloudera.org:8080/3874
Change subject: [client][gutil] introduced ATTRIBUTE_DEPRECATED
......................................................................
[client][gutil] introduced ATTRIBUTE_DEPRECATED
The ATTRIBUTE_DEPRECATED macro is to mark deprecated methods.
An example of usage:
void foo() ATTRIBUTE_DEPRECATED("use bar() instead");
Change-Id: Ib0d3c48fe8b5b599126ff45728d0b8da30ffe082
---
M src/kudu/client/stubs.h
M src/kudu/gutil/port.h
2 files changed, 24 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/74/3874/1
--
To view, visit http://gerrit.cloudera.org:8080/3874
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib0d3c48fe8b5b599126ff45728d0b8da30ffe082
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [client][gutil] introduced ATTRIBUTE DEPRECATED
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: [client][gutil] introduced ATTRIBUTE_DEPRECATED
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/3874
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib0d3c48fe8b5b599126ff45728d0b8da30ffe082
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] [client][gutil] introduced ATTRIBUTE DEPRECATED
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: [client][gutil] introduced ATTRIBUTE_DEPRECATED
......................................................................
Patch Set 1:
Build Started http://104.196.14.100/job/kudu-gerrit/2764/
--
To view, visit http://gerrit.cloudera.org:8080/3874
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib0d3c48fe8b5b599126ff45728d0b8da30ffe082
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] [client][gutil] introduced ATTRIBUTE DEPRECATED
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change.
Change subject: [client][gutil] introduced ATTRIBUTE_DEPRECATED
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/3874
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib0d3c48fe8b5b599126ff45728d0b8da30ffe082
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] [client][gutil] introduced ATTRIBUTE DEPRECATED
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has submitted this change and it was merged.
Change subject: [client][gutil] introduced ATTRIBUTE_DEPRECATED
......................................................................
[client][gutil] introduced ATTRIBUTE_DEPRECATED
The ATTRIBUTE_DEPRECATED macro is to mark deprecated methods.
An example of usage:
void foo() ATTRIBUTE_DEPRECATED("use bar() instead");
Change-Id: Ib0d3c48fe8b5b599126ff45728d0b8da30ffe082
Reviewed-on: http://gerrit.cloudera.org:8080/3874
Reviewed-by: Todd Lipcon <to...@apache.org>
Tested-by: Kudu Jenkins
Reviewed-by: Mike Percy <mp...@apache.org>
---
M src/kudu/client/stubs.h
M src/kudu/gutil/port.h
2 files changed, 24 insertions(+), 0 deletions(-)
Approvals:
Mike Percy: Looks good to me, approved
Todd Lipcon: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/3874
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib0d3c48fe8b5b599126ff45728d0b8da30ffe082
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>