You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by "Turab (via GitHub)" <gi...@apache.org> on 2025/12/04 10:16:57 UTC
[PR] GUACAMOLE-2173: New strings added and typos fixed for Turkish language [guacamole-client]
Turab opened a new pull request, #1134:
URL: https://github.com/apache/guacamole-client/pull/1134
It was staged for version 1.7.0 before, now it is re-based to staging/1.6.1 including the typos fixes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GUACAMOLE-2173: New strings added and typos fixed for Turkish language [guacamole-client]
Posted by "Turab (via GitHub)" <gi...@apache.org>.
Turab commented on PR #1134:
URL: https://github.com/apache/guacamole-client/pull/1134#issuecomment-3615559246
> Overall looks pretty good - just a few lines that should be swapped around to maintain alphabetical order.
>
> Thanks!
Done! They were mere copies of en.json files, but nonetheless, I re-ordered the aforementioned keys. As you told before, if I come across some more in later versions, I will alter the ordering despite their positioning in en.json files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GUACAMOLE-2173: New strings added and typos fixed for Turkish language [guacamole-client]
Posted by "necouchman (via GitHub)" <gi...@apache.org>.
necouchman commented on PR #1134:
URL: https://github.com/apache/guacamole-client/pull/1134#issuecomment-3612574636
> I wonder something: Since main branch has some typos from my previously merged PR, how will this effect the later versions like 1.7.0? Will this new PR be cherry-picked into main or the later staging branches (like staging/1.7.0 for example)?
This will get merged up to `patch`, `main`, and `next` branches, so it should take care of any of those issues. Then, when we go to do a 1.7.0 release, we'll create the `staging/1.7.0` branch from the `main` branch, and it should include all of these fixes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GUACAMOLE-2173: New strings added and typos fixed for Turkish language [guacamole-client]
Posted by "necouchman (via GitHub)" <gi...@apache.org>.
necouchman merged PR #1134:
URL: https://github.com/apache/guacamole-client/pull/1134
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org