[GitHub] [dubbo] Moriadry opened pull request #5699: add consul service discovery test

["Moriadry (GitHub)" <gi...@apache.org>]

## What is the purpose of the change

complete the unit test for consul service discovery module.

## Brief changelog

XXXXX

## Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

- [x] Make sure there is a [GITHUB_issue](https://github.com/apache/dubbo/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when host config not exist #XXX`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in [dubbo samples](https://github.com/apache/dubbo-samples) project.
- [x] Run `mvn clean install -DskipTests=false` & `mvn clean test-compile failsafe:integration-test` to make sure unit-test and integration-test pass.
- [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/dubbo/wiki/Software-donation-guide).


[ Full content available at: https://github.com/apache/dubbo/pull/5699 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo] chickenlj commented on issue #5699: add consul service discovery test

["chickenlj (GitHub)" <gi...@apache.org>]

> @chickenlj Can you show me any example so I can find whether I can dig in it.
> 
> I thought with embedded-consul imported, It should be an integration test somehow?

Yes, I think we can go with embedded Consul, I noticed it also helped us with the potential port conflicting problem.

You can reference here for how to use testcontainers doing Integration Test https://www.testcontainers.org/

[ Full content available at: https://github.com/apache/dubbo/pull/5699 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo] chickenlj commented on issue #5699: add consul service discovery test

["chickenlj (GitHub)" <gi...@apache.org>]

Have you considered making it into a integration test by using some frameworks like TestContainer that leverage Container?

[ Full content available at: https://github.com/apache/dubbo/pull/5699 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org