You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@datasketches.apache.org by "SavicStefan (via GitHub)" <gi...@apache.org> on 2026/09/01 06:29:59 UTC
[PR] Added the check for reading less bytes from buffer [datasketches-cpp]
SavicStefan opened a new pull request, #519:
URL: https://github.com/apache/datasketches-cpp/pull/519
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
Re: [PR] Deserialization must fail if bytes remain after the last entry [datasketches-cpp]
Posted by "proost (via GitHub)" <gi...@apache.org>.
proost commented on PR #519:
URL: https://github.com/apache/datasketches-cpp/pull/519#issuecomment-5526923542
@SavicStefan
Now I understand your intention. you're right that the mismatch is undetectable from the format alone. But that's structural, not a gap to patch. See [this](https://github.com/apache/datasketches-java/blob/3a1bf7f2f22e78c0c227bbe409ce4b4f386f630c/src/main/java/org/apache/datasketches/tuple/SummaryDeserializer.java#L30-L39).
It can't distinguish a wrong summary type from a larger buffer or a SerDe that over-report.
And also some users will be relying on it, This change would break them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
Re: [PR] Deserialization must fail if bytes remain after the last entry [datasketches-cpp]
Posted by "leerho (via GitHub)" <gi...@apache.org>.
leerho closed pull request #519: Deserialization must fail if bytes remain after the last entry
URL: https://github.com/apache/datasketches-cpp/pull/519
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
Re: [PR] Deserialization must fail if bytes remain after the last entry [datasketches-cpp]
Posted by "SavicStefan (via GitHub)" <gi...@apache.org>.
SavicStefan commented on PR #519:
URL: https://github.com/apache/datasketches-cpp/pull/519#issuecomment-5523950561
> Technically, you are right. But it can change implicit contract in the API.
but like serialized format does not identify the summary type, so this is needed to detect that mismatch, wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
Re: [PR] Deserialization must fail if bytes remain after the last entry [datasketches-cpp]
Posted by "leerho (via GitHub)" <gi...@apache.org>.
leerho commented on PR #519:
URL: https://github.com/apache/datasketches-cpp/pull/519#issuecomment-5690268369
I agree with @proost on this. We can't assume that a given MemorySegment is dedicated to a sketch / Summary and nothing else. It is really up to the sketch and the user's code to figure out how many bytes to read. This is true of all our sketches that leverage MemorySegments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org