You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by arina-ielchiieva <gi...@git.apache.org> on 2017/05/18 11:40:01 UTC

[GitHub] drill pull request #842: DRILL-5523: Revert if condition in UnionAllRecordBa...

GitHub user arina-ielchiieva opened a pull request:

    https://github.com/apache/drill/pull/842

    DRILL-5523: Revert if condition in UnionAllRecordBatch changed in DRI…

    …LL-5419
    
    If condition in UnionAllRecordBatch which was changed to correct one in DRILL-5419 but this change caused the regression (DRILL-5521).
    The root cause is not in change itself but rather in missing indication of child column in map types when it is null. There is a big project upcoming re-working json reader implementation, including map types (DRILL-4824) which will fix the problem.
    So far reverting change to initial state so users won't see the regression till DRILL-4824 is merged.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/arina-ielchiieva/drill DRILL-5523

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/drill/pull/842.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #842
    
----

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] drill issue #842: DRILL-5523: Revert if condition in UnionAllRecordBatch cha...

Posted by amansinha100 <gi...@git.apache.org>.
Github user amansinha100 commented on the issue:

    https://github.com/apache/drill/pull/842
  
    +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] drill pull request #842: DRILL-5523: Revert if condition in UnionAllRecordBa...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/drill/pull/842


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] drill issue #842: DRILL-5523: Revert if condition in UnionAllRecordBatch cha...

Posted by arina-ielchiieva <gi...@git.apache.org>.
Github user arina-ielchiieva commented on the issue:

    https://github.com/apache/drill/pull/842
  
    @vvysotskyi since you are working on DRILL-4824, please review pull request and confirm that issue will be fixed after DRILL-4824 is merged.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---