[GitHub] [httpcomponents-client] ok2c commented on pull request #330: HTTPCLIENT-2189 - Use Time APIs for date for the remain classes in the HttpClient API.

[GitBox <gi...@apache.org>]

ok2c commented on pull request #330:
URL: https://github.com/apache/httpcomponents-client/pull/330#issuecomment-980533432


   @arturobernalg 
   
   1. The `Cookie` interface is now coupled with `DateUtils` which is ugly. Please expand those utility methods and remove dependency on `DateUtils`. A bit of code duplication is justified in this particular case.
   2. Is  `@SuppressWarnings("DeprecatedIsStillUsed")` better than shorter @SuppressWarnings("deprecation")? Just asking.
   3. There are still several places where deprecated code is being used and causes deprecation warning at compile time. We need to get rid of those. I also propose that test cases for deprecated methods get dropped. No need to keep them if new methods pass the same test. Ideally there should be no deprecation warnings. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org