[jira] [Comment Edited] (OAK-3606) Improvements for IndexStatsMBean usage

["Manfred Baedke (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OAK-3606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15708750#comment-15708750 ] 

Manfred Baedke edited comment on OAK-3606 at 11/30/16 2:36 PM:
---------------------------------------------------------------

I will add an additional getter to AllIndexStatsMBean:
{code}
    String getOldestStartOfLastSuccessIndexing(String ignoreOlderThan)
{code}
that will work like the existing method but will only take into account dates that are newer than the one passed as an argument. The reason is that a given test case may modify async indexes, but usually not all of them. The startOfLastSuccessfulIndexing date (I renamed it for better clarity) of the latter will stay older than the start date of the test case.
Feel free to suggest more elegant solutions.


was (Author: baedke):
I will add an additional getter to AllIndexStatsMBean:
{code}
    String getOldestStartOfLastSuccessIndexing(String ignoreOlderThan)
{code}
that will return like the existing method but will only take into account dates that are newer than the one passed as an argument. The reason is that a given test case may modify async indexes, but usually not all of them. The startOfLastSuccessfulIndexing date (I renamed it for better clarity) of the latter will stay older than the start date of the test case.
Feel free to suggest more elegant solutions.

> Improvements for IndexStatsMBean usage
> --------------------------------------
>
>                 Key: OAK-3606
>                 URL: https://issues.apache.org/jira/browse/OAK-3606
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: core, lucene
>    Affects Versions: 1.3.9
>            Reporter: Thierry Ygé
>            Assignee: Manfred Baedke
>             Fix For: 1.6, 1.5.15
>
>         Attachments: adding_new_MBean.patch, new_mbean_interface_and_implementation.patch
>
>
> When running integration tests, it is common to have the need to wait for the async indexes to have been executed. So that the test can successfully validate operations that depend on the search result.
> With the current IndexStatsMBean implementation it cannot return the start time of the last successful indexing. It provide a "LastIndexedTime" which is not sufficient to know if changes made recently are now indexed.
> The idea is to set the start time as value of a new attribute (i.e "StartLastSuccessIndexedTime") to the IndexStatsMBean.
> Then create a new Mbean that calculate from all existing IndexStatsMBean (as multiple are possible now) the oldest "StartLastSuccessIndexedTime".
> That will allow integration tests to be able to wait until that oldest "StartLastSuccessIndexedTime" is greater than the time it started to wait.
> Attached is a sample patch containing the necessary changes (for a Oak core 1.4.0-SNAPSHOT).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)