You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@paimon.apache.org by "steFaiz (via GitHub)" <gi...@apache.org> on 2026/02/09 12:53:36 UTC

[PR] [core] fix btree index row range [paimon]

steFaiz opened a new pull request, #7242:
URL: https://github.com/apache/paimon/pull/7242

   <!-- Please specify the module before the PR name: [core] ... or [flink] ... -->
   
   ### Purpose
   The row range is miscalculated by [first_row_id, first_row_id + row_count], should minus 1
   
   <!-- Linking this pull request to the issue -->
   <!-- What is the purpose of the change -->
   
   ### Tests
   
   <!-- List UT and IT cases to verify this change -->
   
   ### API and Format
   
   <!-- Does this change affect API or storage format -->
   
   ### Documentation
   
   <!-- Does this change introduce a new feature -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [core] fix btree index row range [paimon]

Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi merged PR #7242:
URL: https://github.com/apache/paimon/pull/7242


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [core] fix btree index row range [paimon]

Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on PR #7242:
URL: https://github.com/apache/paimon/pull/7242#issuecomment-3872185374

   +1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [core] fix btree index row range [paimon]

Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on code in PR #7242:
URL: https://github.com/apache/paimon/pull/7242#discussion_r2782505658


##########
paimon-core/src/main/java/org/apache/paimon/globalindex/btree/BTreeGlobalIndexBuilder.java:
##########
@@ -247,7 +247,7 @@ public static Range calcRowRange(List<DataSplit> dataSplits) {
             for (DataFileMeta file : dataSplit.dataFiles()) {
                 long firstRowId = file.nonNullFirstRowId();
                 start = Math.min(start, firstRowId);
-                end = Math.max(end, firstRowId + file.rowCount());
+                end = Math.max(end, firstRowId + file.rowCount() - 1);

Review Comment:
   Can you add a case for this?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org