You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Owen O'Malley (JIRA)" <ji...@apache.org> on 2008/09/25 18:31:44 UTC
[jira] Created: (HADOOP-4275) New public methods added to the *ID
classes
New public methods added to the *ID classes
-------------------------------------------
Key: HADOOP-4275
URL: https://issues.apache.org/jira/browse/HADOOP-4275
Project: Hadoop Core
Issue Type: Bug
Reporter: Owen O'Malley
Assignee: Owen O'Malley
Fix For: 0.19.0
The mapred.*ID classes have had their interfaces expanded with inappropriate public methods that should be removed before they are released.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4275) New public methods added to the *ID
classes
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12635147#action_12635147 ]
Hudson commented on HADOOP-4275:
--------------------------------
Integrated in Hadoop-trunk #616 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/616/])
> New public methods added to the *ID classes
> -------------------------------------------
>
> Key: HADOOP-4275
> URL: https://issues.apache.org/jira/browse/HADOOP-4275
> Project: Hadoop Core
> Issue Type: Bug
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Fix For: 0.19.0
>
> Attachments: hadoop-4275-2.patch, hadoop-4275.patch
>
>
> The mapred.*ID classes have had their interfaces expanded with inappropriate public methods that should be removed before they are released.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4275) New public methods added to the *ID
classes
Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12634677#action_12634677 ]
Owen O'Malley commented on HADOOP-4275:
---------------------------------------
Sorry, this is just the JobID class. We should move the isJobNameValid to the JobTracker, where it is used.
> New public methods added to the *ID classes
> -------------------------------------------
>
> Key: HADOOP-4275
> URL: https://issues.apache.org/jira/browse/HADOOP-4275
> Project: Hadoop Core
> Issue Type: Bug
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Fix For: 0.19.0
>
>
> The mapred.*ID classes have had their interfaces expanded with inappropriate public methods that should be removed before they are released.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4275) New public methods added to the *ID
classes
Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Owen O'Malley updated HADOOP-4275:
----------------------------------
Status: Open (was: Patch Available)
> New public methods added to the *ID classes
> -------------------------------------------
>
> Key: HADOOP-4275
> URL: https://issues.apache.org/jira/browse/HADOOP-4275
> Project: Hadoop Core
> Issue Type: Bug
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Fix For: 0.19.0
>
> Attachments: hadoop-4275-2.patch, hadoop-4275.patch
>
>
> The mapred.*ID classes have had their interfaces expanded with inappropriate public methods that should be removed before they are released.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4275) New public methods added to the *ID
classes
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12634883#action_12634883 ]
Hadoop QA commented on HADOOP-4275:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12390992/hadoop-4275-2.patch
against trunk revision 699119.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 Eclipse classpath. The patch retains Eclipse classpath integrity.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3380/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3380/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3380/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3380/console
This message is automatically generated.
> New public methods added to the *ID classes
> -------------------------------------------
>
> Key: HADOOP-4275
> URL: https://issues.apache.org/jira/browse/HADOOP-4275
> Project: Hadoop Core
> Issue Type: Bug
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Fix For: 0.19.0
>
> Attachments: hadoop-4275-2.patch, hadoop-4275.patch
>
>
> The mapred.*ID classes have had their interfaces expanded with inappropriate public methods that should be removed before they are released.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4275) New public methods added to the *ID
classes
Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Owen O'Malley updated HADOOP-4275:
----------------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
I just committed this.
> New public methods added to the *ID classes
> -------------------------------------------
>
> Key: HADOOP-4275
> URL: https://issues.apache.org/jira/browse/HADOOP-4275
> Project: Hadoop Core
> Issue Type: Bug
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Fix For: 0.19.0
>
> Attachments: hadoop-4275-2.patch, hadoop-4275.patch
>
>
> The mapred.*ID classes have had their interfaces expanded with inappropriate public methods that should be removed before they are released.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4275) New public methods added to the *ID
classes
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12634736#action_12634736 ]
Hadoop QA commented on HADOOP-4275:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12390972/hadoop-4275.patch
against trunk revision 699119.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.
-1 patch. The patch command could not apply the patch.
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3374/console
This message is automatically generated.
> New public methods added to the *ID classes
> -------------------------------------------
>
> Key: HADOOP-4275
> URL: https://issues.apache.org/jira/browse/HADOOP-4275
> Project: Hadoop Core
> Issue Type: Bug
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Fix For: 0.19.0
>
> Attachments: hadoop-4275.patch
>
>
> The mapred.*ID classes have had their interfaces expanded with inappropriate public methods that should be removed before they are released.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4275) New public methods added to the *ID
classes
Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Owen O'Malley updated HADOOP-4275:
----------------------------------
Attachment: hadoop-4275.patch
This patch just moves isJobValidName from a public static method in JobID to a private method in JobTracker.
> New public methods added to the *ID classes
> -------------------------------------------
>
> Key: HADOOP-4275
> URL: https://issues.apache.org/jira/browse/HADOOP-4275
> Project: Hadoop Core
> Issue Type: Bug
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Fix For: 0.19.0
>
> Attachments: hadoop-4275.patch
>
>
> The mapred.*ID classes have had their interfaces expanded with inappropriate public methods that should be removed before they are released.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4275) New public methods added to the *ID
classes
Posted by "Robert Chansler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Chansler updated HADOOP-4275:
------------------------------------
Component/s: mapred
> New public methods added to the *ID classes
> -------------------------------------------
>
> Key: HADOOP-4275
> URL: https://issues.apache.org/jira/browse/HADOOP-4275
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Fix For: 0.19.0
>
> Attachments: hadoop-4275-2.patch, hadoop-4275.patch
>
>
> The mapred.*ID classes have had their interfaces expanded with inappropriate public methods that should be removed before they are released.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4275) New public methods added to the *ID
classes
Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Owen O'Malley updated HADOOP-4275:
----------------------------------
Status: Patch Available (was: Open)
> New public methods added to the *ID classes
> -------------------------------------------
>
> Key: HADOOP-4275
> URL: https://issues.apache.org/jira/browse/HADOOP-4275
> Project: Hadoop Core
> Issue Type: Bug
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Fix For: 0.19.0
>
> Attachments: hadoop-4275.patch
>
>
> The mapred.*ID classes have had their interfaces expanded with inappropriate public methods that should be removed before they are released.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4275) New public methods added to the *ID
classes
Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Owen O'Malley updated HADOOP-4275:
----------------------------------
Attachment: hadoop-4275-2.patch
I forgot to include the --no-prefix to git.
> New public methods added to the *ID classes
> -------------------------------------------
>
> Key: HADOOP-4275
> URL: https://issues.apache.org/jira/browse/HADOOP-4275
> Project: Hadoop Core
> Issue Type: Bug
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Fix For: 0.19.0
>
> Attachments: hadoop-4275-2.patch, hadoop-4275.patch
>
>
> The mapred.*ID classes have had their interfaces expanded with inappropriate public methods that should be removed before they are released.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4275) New public methods added to the *ID
classes
Posted by "Enis Soztutar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12634886#action_12634886 ]
Enis Soztutar commented on HADOOP-4275:
---------------------------------------
+1, looks good.
> New public methods added to the *ID classes
> -------------------------------------------
>
> Key: HADOOP-4275
> URL: https://issues.apache.org/jira/browse/HADOOP-4275
> Project: Hadoop Core
> Issue Type: Bug
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Fix For: 0.19.0
>
> Attachments: hadoop-4275-2.patch, hadoop-4275.patch
>
>
> The mapred.*ID classes have had their interfaces expanded with inappropriate public methods that should be removed before they are released.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4275) New public methods added to the *ID
classes
Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Owen O'Malley updated HADOOP-4275:
----------------------------------
Status: Patch Available (was: Open)
> New public methods added to the *ID classes
> -------------------------------------------
>
> Key: HADOOP-4275
> URL: https://issues.apache.org/jira/browse/HADOOP-4275
> Project: Hadoop Core
> Issue Type: Bug
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Fix For: 0.19.0
>
> Attachments: hadoop-4275-2.patch, hadoop-4275.patch
>
>
> The mapred.*ID classes have had their interfaces expanded with inappropriate public methods that should be removed before they are released.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.