[GitHub] [spark] mccheah commented on a change in pull request #25361: [SPARK-28625][Core] Indeterminate shuffle support in Shuffle Writer API

[GitBox <gi...@apache.org>]

mccheah commented on a change in pull request #25361: [SPARK-28625][Core] Indeterminate shuffle support in Shuffle Writer API
URL: https://github.com/apache/spark/pull/25361#discussion_r310720109
 
 

 ##########
 File path: core/src/main/java/org/apache/spark/shuffle/api/ShuffleExecutorComponents.java
 ##########
 @@ -39,16 +39,20 @@
   /**
    * Called once per map task to create a writer that will be responsible for persisting all the
    * partitioned bytes written by that map task.
-   *  @param shuffleId Unique identifier for the shuffle the map task is a part of
+   * @param shuffleId Unique identifier for the shuffle the map task is a part of
+   * @param shuffleGenerationId The shuffle generation ID of the stage that this task belongs to,
 
 Review comment:
   Why can't we just use the `mapTaskAttemptId`? (In fact I wonder if we can just have a global identifier and not even need `shuffleId` and `mapId` and just use `mapTaskAttemptId` as a global identifier, but that might be a bit ambitious.)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org