You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by "Hisoka-X (via GitHub)" <gi...@apache.org> on 2025/08/19 07:49:32 UTC

[I] [Improve][Zeta] Remove distributed lock when store metrics imap [seatunnel]

Hisoka-X opened a new issue, #9727:
URL: https://github.com/apache/seatunnel/issues/9727

   ### Search before asking
   
   - [x] I had searched in the [feature](https://github.com/apache/seatunnel/issues?q=is%3Aissue+label%3A%22Feature%22) and found no similar feature requirement.
   
   
   ### Description
   
   Please refer https://github.com/apache/seatunnel/pull/9427#pullrequestreview-2920391531 and https://github.com/apache/seatunnel/pull/9696#discussion_r2284274456
   
   ### Usage Scenario
   
   _No response_
   
   ### Related issues
   
   _No response_
   
   ### Are you willing to submit a PR?
   
   - [ ] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [x] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [Improve][Zeta] Remove distributed lock when store metrics imap [seatunnel]

Posted by "Hisoka-X (via GitHub)" <gi...@apache.org>.
Hisoka-X closed issue #9727: [Improve][Zeta] Remove distributed lock when store metrics imap
URL: https://github.com/apache/seatunnel/issues/9727


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [Improve][Zeta] Remove distributed lock when store metrics imap [seatunnel]

Posted by "dybyte (via GitHub)" <gi...@apache.org>.
dybyte commented on issue #9727:
URL: https://github.com/apache/seatunnel/issues/9727#issuecomment-3210630655

   Hi @Hisoka-X, as discussed earlier, could you assign this issue to me? Thanks!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [Improve][Zeta] Remove distributed lock when store metrics imap [seatunnel]

Posted by "Hisoka-X (via GitHub)" <gi...@apache.org>.
Hisoka-X commented on issue #9727:
URL: https://github.com/apache/seatunnel/issues/9727#issuecomment-3199626907

   cc @dybyte 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [Improve][Zeta] Remove distributed lock when store metrics imap [seatunnel]

Posted by "dybyte (via GitHub)" <gi...@apache.org>.
dybyte commented on issue #9727:
URL: https://github.com/apache/seatunnel/issues/9727#issuecomment-3215987426

   Hi @Hisoka-X , I have one concern: If we remove the distributed lock and rely on `TaskExecutionService` to report metrics to the Master via Operations, multiple workers may concurrently send updates to the Master. I’m not entirely sure if this alone fully addresses the concurrency issues, so I’d appreciate your guidance: if my understanding is correct, would it be more appropriate to use `IMap.compute()` or an `EntryProcessor` in this scenario?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [Improve][Zeta] Remove distributed lock when store metrics imap [seatunnel]

Posted by "Hisoka-X (via GitHub)" <gi...@apache.org>.
Hisoka-X commented on issue #9727:
URL: https://github.com/apache/seatunnel/issues/9727#issuecomment-3216127089

   @dybyte You are right!
   
   > multiple workers may concurrently send updates to the Master
   
   This is indeed problem we need to consider.
   
   > would it be more appropriate to use IMap.compute() or an EntryProcessor in this scenario?
   
   I prefer to use synchronized blocks when modify imap. Can you do a performance comparison?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org