You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@camel.apache.org by snowch <gi...@git.apache.org> on 2017/08/22 06:58:55 UTC

[GitHub] camel pull request #1897: CAMEL-11682: Add sasl.jaas.config setting

GitHub user snowch opened a pull request:

    https://github.com/apache/camel/pull/1897

    CAMEL-11682: Add sasl.jaas.config setting

    I have tested the PR against IBM MessageHub and it worked with the following routes:
    
    ```
    final String brokers = "kafka04-prod01.messagehub.services.eu-de.bluemix.net:9093,kafka05-prod01.messagehub.services.eu-de.bluemix.net:9093";
    
    final String saslJaasConfig = "org.apache.kafka.common.security.plain.PlainLoginModule required username=\"USERNAME\" password=\"PASSWORD\";";
    					
    from("direct:in")
    .to("kafka:test?" 
        + "brokers=" + brokers
        + "&saslMechanism=PLAIN"  
        + "&securityProtocol=SASL_SSL"
        + "&sslProtocol=TLSv1.2"
        + "&sslEnabledProtocols=TLSv1.2" 
        + "&sslEndpointAlgorithm=HTTPS"
        + "&saslJaasConfig=" + saslJaasConfig );
    ```
    and KafkaConsumer
    
    ```
    final String brokers = "kafka04-prod01.messagehub.services.eu-de.bluemix.net:9093,kafka05-prod01.messagehub.services.eu-de.bluemix.net:9093";
    
    final String saslJaasConfig = "org.apache.kafka.common.security.plain.PlainLoginModule required username=\"USERNAME\" password=\"PASSWORD\";";
    					
    from("kafka:test?" 
        + "brokers=" + brokers
        + "&saslMechanism=PLAIN"  
        + "&securityProtocol=SASL_SSL"
        + "&sslProtocol=TLSv1.2"
        + "&sslEnabledProtocols=TLSv1.2" 
        + "&sslEndpointAlgorithm=HTTPS"
        + "&saslJaasConfig=" + saslJaasConfig
        + "&groupId=mygroup")
    .to("stream:out");
    ```
    
    The camel-kafka tests were failing on master before I made my changes.  The failures were:
    
    ```
    [ERROR] Failures:
    [ERROR] org.apache.camel.component.kafka.KafkaConsumerOffsetRepositoryEmptyTest.shouldStartFromBeginningWithEmptyOffsetRepository(org.apache.camel.component.kafka.KafkaConsumerOffsetRepositoryEmptyTest)
    [ERROR]   Run 1: KafkaConsumerOffsetRepositoryEmptyTest.shouldStartFromBeginningWithEmptyOffsetRepository:74 mock://result Received message count. Expected: <10> but was: <0>
    [ERROR]   Run 2: KafkaConsumerOffsetRepositoryEmptyTest.shouldStartFromBeginningWithEmptyOffsetRepository:74 mock://result Received message count. Expected: <10> but was: <0>
    [ERROR]   Run 3: KafkaConsumerOffsetRepositoryEmptyTest.shouldStartFromBeginningWithEmptyOffsetRepository:74 mock://result Received message count. Expected: <10> but was: <0>
    [INFO]
    [ERROR] org.apache.camel.component.kafka.KafkaConsumerOffsetRepositoryResumeTest.shouldResumeFromAnyParticularOffset(org.apache.camel.component.kafka.KafkaConsumerOffsetRepositoryResumeTest)
    [ERROR]   Run 1: KafkaConsumerOffsetRepositoryResumeTest.shouldResumeFromAnyParticularOffset:75 mock://result Received message count. Expected: <3> but was: <0>
    [ERROR]   Run 2: KafkaConsumerOffsetRepositoryResumeTest.shouldResumeFromAnyParticularOffset:75 mock://result Received message count. Expected: <3> but was: <0>
    [ERROR]   Run 3: KafkaConsumerOffsetRepositoryResumeTest.shouldResumeFromAnyParticularOffset:75 mock://result Received message count. Expected: <3> but was: <0>
    [INFO]
    [INFO]
    [ERROR] Tests run: 43, Failures: 2, Errors: 0, Skipped: 2
    ```

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/snowch/camel CAMEL-11682

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/camel/pull/1897.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1897
    
----
commit fd4c44e1116413b3f89ac5f07d30381bcbb86e1d
Author: christopher snow <ch...@gmail.com>
Date:   2017-08-22T06:50:13Z

    CAMEL-11682: Add sasl.jaas.config setting

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] camel pull request #1897: CAMEL-11682: Add sasl.jaas.config setting

Posted by snowch <gi...@git.apache.org>.
Github user snowch closed the pull request at:

    https://github.com/apache/camel/pull/1897


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] camel pull request #1897: CAMEL-11682: Add sasl.jaas.config setting

Posted by snowch <gi...@git.apache.org>.
GitHub user snowch reopened a pull request:

    https://github.com/apache/camel/pull/1897

    CAMEL-11682: Add sasl.jaas.config setting

    I have tested the PR against IBM MessageHub and it worked with the following routes:
    
    ```
    final String brokers = "kafka04-prod01.messagehub.services.eu-de.bluemix.net:9093,kafka05-prod01.messagehub.services.eu-de.bluemix.net:9093";
    
    final String saslJaasConfig = "org.apache.kafka.common.security.plain.PlainLoginModule required username=\"USERNAME\" password=\"PASSWORD\";";
    					
    from("direct:in")
    .to("kafka:test?" 
        + "brokers=" + brokers
        + "&saslMechanism=PLAIN"  
        + "&securityProtocol=SASL_SSL"
        + "&sslProtocol=TLSv1.2"
        + "&sslEnabledProtocols=TLSv1.2" 
        + "&sslEndpointAlgorithm=HTTPS"
        + "&saslJaasConfig=" + saslJaasConfig );
    ```
    and KafkaConsumer
    
    ```
    final String brokers = "kafka04-prod01.messagehub.services.eu-de.bluemix.net:9093,kafka05-prod01.messagehub.services.eu-de.bluemix.net:9093";
    
    final String saslJaasConfig = "org.apache.kafka.common.security.plain.PlainLoginModule required username=\"USERNAME\" password=\"PASSWORD\";";
    					
    from("kafka:test?" 
        + "brokers=" + brokers
        + "&saslMechanism=PLAIN"  
        + "&securityProtocol=SASL_SSL"
        + "&sslProtocol=TLSv1.2"
        + "&sslEnabledProtocols=TLSv1.2" 
        + "&sslEndpointAlgorithm=HTTPS"
        + "&saslJaasConfig=" + saslJaasConfig
        + "&groupId=mygroup")
    .to("stream:out");
    ```
    
    The camel-kafka tests were failing on master before I made my changes.  The failures were:
    
    ```
    [ERROR] Failures:
    [ERROR] org.apache.camel.component.kafka.KafkaConsumerOffsetRepositoryEmptyTest.shouldStartFromBeginningWithEmptyOffsetRepository(org.apache.camel.component.kafka.KafkaConsumerOffsetRepositoryEmptyTest)
    [ERROR]   Run 1: KafkaConsumerOffsetRepositoryEmptyTest.shouldStartFromBeginningWithEmptyOffsetRepository:74 mock://result Received message count. Expected: <10> but was: <0>
    [ERROR]   Run 2: KafkaConsumerOffsetRepositoryEmptyTest.shouldStartFromBeginningWithEmptyOffsetRepository:74 mock://result Received message count. Expected: <10> but was: <0>
    [ERROR]   Run 3: KafkaConsumerOffsetRepositoryEmptyTest.shouldStartFromBeginningWithEmptyOffsetRepository:74 mock://result Received message count. Expected: <10> but was: <0>
    [INFO]
    [ERROR] org.apache.camel.component.kafka.KafkaConsumerOffsetRepositoryResumeTest.shouldResumeFromAnyParticularOffset(org.apache.camel.component.kafka.KafkaConsumerOffsetRepositoryResumeTest)
    [ERROR]   Run 1: KafkaConsumerOffsetRepositoryResumeTest.shouldResumeFromAnyParticularOffset:75 mock://result Received message count. Expected: <3> but was: <0>
    [ERROR]   Run 2: KafkaConsumerOffsetRepositoryResumeTest.shouldResumeFromAnyParticularOffset:75 mock://result Received message count. Expected: <3> but was: <0>
    [ERROR]   Run 3: KafkaConsumerOffsetRepositoryResumeTest.shouldResumeFromAnyParticularOffset:75 mock://result Received message count. Expected: <3> but was: <0>
    [INFO]
    [INFO]
    [ERROR] Tests run: 43, Failures: 2, Errors: 0, Skipped: 2
    ```

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/snowch/camel CAMEL-11682

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/camel/pull/1897.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1897
    
----
commit fd4c44e1116413b3f89ac5f07d30381bcbb86e1d
Author: christopher snow <ch...@gmail.com>
Date:   2017-08-22T06:50:13Z

    CAMEL-11682: Add sasl.jaas.config setting

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] camel pull request #1897: CAMEL-11682: Add sasl.jaas.config setting

Posted by snowch <gi...@git.apache.org>.
Github user snowch closed the pull request at:

    https://github.com/apache/camel/pull/1897


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---