You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lenya.apache.org by Joern Nettingsmeier <po...@uni-due.de> on 2006/06/08 17:32:19 UTC
Re: svn commit: r412718 - in /lenya/trunk/src: modules/cforms/config/menu.xsp
modules/links/config/menu.xsp modules/opendocument/config/menus/opendocument.xsp
modules/xhtml/config/menu.xsp pubs/default/modules/homepage/config/menus/homepage.xsp
andreas@apache.org wrote:
> Author: andreas
> Date: Thu Jun 8 03:45:46 2006
> New Revision: 412718
>
> URL: http://svn.apache.org/viewvc?rev=412718&view=rev
> Log:
> Added check for document existence to module menus to avoid exception for non-existing documents in the site area.
>
> Modified:
> lenya/trunk/src/modules/cforms/config/menu.xsp
> lenya/trunk/src/modules/links/config/menu.xsp
> lenya/trunk/src/modules/opendocument/config/menus/opendocument.xsp
> lenya/trunk/src/modules/xhtml/config/menu.xsp
> lenya/trunk/src/pubs/default/modules/homepage/config/menus/homepage.xsp
this is a lot of code duplication. isn't there a way to move this
snippet into an xsp "functions" file, maybe via cinclude and friends?
--
"Án nýrra verka, án nútimans, hættir fortíðin að vekja áhuga."
"Without new works, without the present the past will cease to be of
interest."
- Ásmundur Sveinsson (1893-1982)
--
Jörn Nettingsmeier, EDV-Administrator
Institut für Politikwissenschaft
Universität Duisburg-Essen, Standort Duisburg
Mail: pol-admin@uni-due.de, Telefon: 0203/379-2736
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
For additional commands, e-mail: dev-help@lenya.apache.org
Re: svn commit: r412718 - in /lenya/trunk/src: modules/cforms/config/menu.xsp
modules/links/config/menu.xsp modules/opendocument/config/menus/opendocument.xsp
modules/xhtml/config/menu.xsp pubs/default/modules/homepage/config/menus/homepage.xsp
Posted by Andreas Hartmann <an...@apache.org>.
Joern Nettingsmeier wrote:
> andreas@apache.org wrote:
>> Author: andreas
>> Date: Thu Jun 8 03:45:46 2006
>> New Revision: 412718
>>
>> URL: http://svn.apache.org/viewvc?rev=412718&view=rev
>> Log:
>> Added check for document existence to module menus to avoid exception for non-existing documents in the site area.
>>
>> Modified:
>> lenya/trunk/src/modules/cforms/config/menu.xsp
>> lenya/trunk/src/modules/links/config/menu.xsp
>> lenya/trunk/src/modules/opendocument/config/menus/opendocument.xsp
>> lenya/trunk/src/modules/xhtml/config/menu.xsp
>> lenya/trunk/src/pubs/default/modules/homepage/config/menus/homepage.xsp
>
> this is a lot of code duplication.
Yes, I don't like it either :(
> isn't there a way to move this
> snippet into an xsp "functions" file, maybe via cinclude and friends?
Hmmm, I wouldn't like to add any indirections / includes to XSP unless
this is absolutely necessary. Maybe we can optimize the input module(s)
to require less checking code in the menu XSP?
BTW, good to see that you're a critical commit list reader :)
-- Andreas
--
Andreas Hartmann
Wyona Inc. - Open Source Content Management - Apache Lenya
http://www.wyona.com http://lenya.apache.org
andreas.hartmann@wyona.com andreas@apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
For additional commands, e-mail: dev-help@lenya.apache.org