You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Boris Shkolnik (JIRA)" <ji...@apache.org> on 2010/02/27 03:38:05 UTC
[jira] Created: (HDFS-1006) getImage/putImage http requests should
be https for the case of security enabled.
getImage/putImage http requests should be https for the case of security enabled.
---------------------------------------------------------------------------------
Key: HDFS-1006
URL: https://issues.apache.org/jira/browse/HDFS-1006
Project: Hadoop HDFS
Issue Type: Bug
Reporter: Boris Shkolnik
should use https:// and port 50475
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HDFS-1006) getImage/putImage http requests should
be https for the case of security enabled.
Posted by "Boris Shkolnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1006?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Boris Shkolnik reassigned HDFS-1006:
------------------------------------
Assignee: Boris Shkolnik
> getImage/putImage http requests should be https for the case of security enabled.
> ---------------------------------------------------------------------------------
>
> Key: HDFS-1006
> URL: https://issues.apache.org/jira/browse/HDFS-1006
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Boris Shkolnik
> Assignee: Boris Shkolnik
> Attachments: HDFS-1006-BP20.patch
>
>
> should use https:// and port 50475
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-1006) getImage/putImage http requests
should be https for the case of security enabled.
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12886601#action_12886601 ]
Hudson commented on HDFS-1006:
------------------------------
Integrated in Hadoop-Hdfs-trunk-Commit #335 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/335/])
HDFS-1006. getImage/putImage http requests should be https for the case of security enabled.
> getImage/putImage http requests should be https for the case of security enabled.
> ---------------------------------------------------------------------------------
>
> Key: HDFS-1006
> URL: https://issues.apache.org/jira/browse/HDFS-1006
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Boris Shkolnik
> Assignee: Boris Shkolnik
> Fix For: 0.22.0
>
> Attachments: HDFS-1006-BP20.patch, hdfs-1006-bugfix-1.patch, HDFS-1006-trunk-2.patch, HDFS-1006-trunk.patch, HDFS-1006-Y20.1.patch, HDFS-1006-Y20.patch
>
>
> should use https:// and port 50475
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HDFS-1006) getImage/putImage http requests should
be https for the case of security enabled.
Posted by "Jakob Homan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1006?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jakob Homan updated HDFS-1006:
------------------------------
Status: Patch Available (was: Open)
Re-submitting to Hudson.
> getImage/putImage http requests should be https for the case of security enabled.
> ---------------------------------------------------------------------------------
>
> Key: HDFS-1006
> URL: https://issues.apache.org/jira/browse/HDFS-1006
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Boris Shkolnik
> Assignee: Boris Shkolnik
> Fix For: 0.22.0
>
> Attachments: HDFS-1006-BP20.patch, hdfs-1006-bugfix-1.patch, HDFS-1006-trunk-2.patch, HDFS-1006-trunk.patch, HDFS-1006-Y20.1.patch, HDFS-1006-Y20.patch
>
>
> should use https:// and port 50475
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-1006) getImage/putImage http requests
should be https for the case of security enabled.
Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12886232#action_12886232 ]
Devaraj Das commented on HDFS-1006:
-----------------------------------
You missed setting:
{noformat}infoServer.setAttribute("secondary.name.node", this);{noformat}
You switched from using StringBuilder to StringBuffer in TransferFsImager.java. Is that deliberate?
I am not sure whether the SecondaryNameNode->PrimaryNameNode communication will work if security is enabled and the configured address (accessed in SecondaryNameNode.getInfoServer) is a wildcard address. If not, should we throw an error?
> getImage/putImage http requests should be https for the case of security enabled.
> ---------------------------------------------------------------------------------
>
> Key: HDFS-1006
> URL: https://issues.apache.org/jira/browse/HDFS-1006
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Boris Shkolnik
> Assignee: Boris Shkolnik
> Fix For: 0.22.0
>
> Attachments: HDFS-1006-BP20.patch, hdfs-1006-bugfix-1.patch, HDFS-1006-trunk.patch, HDFS-1006-Y20.1.patch, HDFS-1006-Y20.patch
>
>
> should use https:// and port 50475
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HDFS-1006) getImage/putImage http requests should
be https for the case of security enabled.
Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1006?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Devaraj Das updated HDFS-1006:
------------------------------
Attachment: hdfs-1006-bugfix-1.patch
Patch that removes unnecessary logins (for Y20s)
> getImage/putImage http requests should be https for the case of security enabled.
> ---------------------------------------------------------------------------------
>
> Key: HDFS-1006
> URL: https://issues.apache.org/jira/browse/HDFS-1006
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Boris Shkolnik
> Assignee: Boris Shkolnik
> Attachments: HDFS-1006-BP20.patch, hdfs-1006-bugfix-1.patch, HDFS-1006-Y20.1.patch, HDFS-1006-Y20.patch
>
>
> should use https:// and port 50475
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-1006) getImage/putImage http requests
should be https for the case of security enabled.
Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12886570#action_12886570 ]
Devaraj Das commented on HDFS-1006:
-----------------------------------
+1
> getImage/putImage http requests should be https for the case of security enabled.
> ---------------------------------------------------------------------------------
>
> Key: HDFS-1006
> URL: https://issues.apache.org/jira/browse/HDFS-1006
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Boris Shkolnik
> Assignee: Boris Shkolnik
> Fix For: 0.22.0
>
> Attachments: HDFS-1006-BP20.patch, hdfs-1006-bugfix-1.patch, HDFS-1006-trunk-2.patch, HDFS-1006-trunk.patch, HDFS-1006-Y20.1.patch, HDFS-1006-Y20.patch
>
>
> should use https:// and port 50475
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HDFS-1006) getImage/putImage http requests should
be https for the case of security enabled.
Posted by "Jakob Homan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1006?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jakob Homan updated HDFS-1006:
------------------------------
Status: Resolved (was: Patch Available)
Hadoop Flags: [Reviewed]
Resolution: Fixed
I've committed this. Resolving as fixed.
> getImage/putImage http requests should be https for the case of security enabled.
> ---------------------------------------------------------------------------------
>
> Key: HDFS-1006
> URL: https://issues.apache.org/jira/browse/HDFS-1006
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Boris Shkolnik
> Assignee: Boris Shkolnik
> Fix For: 0.22.0
>
> Attachments: HDFS-1006-BP20.patch, hdfs-1006-bugfix-1.patch, HDFS-1006-trunk-2.patch, HDFS-1006-trunk.patch, HDFS-1006-Y20.1.patch, HDFS-1006-Y20.patch
>
>
> should use https:// and port 50475
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-1006) getImage/putImage http requests
should be https for the case of security enabled.
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12886237#action_12886237 ]
Hadoop QA commented on HDFS-1006:
---------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12448939/HDFS-1006-trunk.patch
against trunk revision 961495.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed core unit tests.
-1 contrib tests. The patch failed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/425/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/425/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/425/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/425/console
This message is automatically generated.
> getImage/putImage http requests should be https for the case of security enabled.
> ---------------------------------------------------------------------------------
>
> Key: HDFS-1006
> URL: https://issues.apache.org/jira/browse/HDFS-1006
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Boris Shkolnik
> Assignee: Boris Shkolnik
> Fix For: 0.22.0
>
> Attachments: HDFS-1006-BP20.patch, hdfs-1006-bugfix-1.patch, HDFS-1006-trunk.patch, HDFS-1006-Y20.1.patch, HDFS-1006-Y20.patch
>
>
> should use https:// and port 50475
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HDFS-1006) getImage/putImage http requests should
be https for the case of security enabled.
Posted by "Jakob Homan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1006?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jakob Homan updated HDFS-1006:
------------------------------
Attachment: HDFS-1006-trunk.patch
Trunk for patch, pretty much. The bugfix that was added depends on HDFS-1045, which itself depended on the original 1006. This patch doesn't include the bugfix, which will be included as part of 1045, which is probably the more correct place for it. Forward port is straight-forward and, due to the Kerberos, not unit testable, but has been manually tested at Y!....
> getImage/putImage http requests should be https for the case of security enabled.
> ---------------------------------------------------------------------------------
>
> Key: HDFS-1006
> URL: https://issues.apache.org/jira/browse/HDFS-1006
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Boris Shkolnik
> Assignee: Boris Shkolnik
> Attachments: HDFS-1006-BP20.patch, hdfs-1006-bugfix-1.patch, HDFS-1006-trunk.patch, HDFS-1006-Y20.1.patch, HDFS-1006-Y20.patch
>
>
> should use https:// and port 50475
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HDFS-1006) getImage/putImage http requests should
be https for the case of security enabled.
Posted by "Jakob Homan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1006?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jakob Homan updated HDFS-1006:
------------------------------
Status: Patch Available (was: Open)
Affects Version/s: 0.22.0
Fix Version/s: 0.22.0
submitting patch.
> getImage/putImage http requests should be https for the case of security enabled.
> ---------------------------------------------------------------------------------
>
> Key: HDFS-1006
> URL: https://issues.apache.org/jira/browse/HDFS-1006
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Boris Shkolnik
> Assignee: Boris Shkolnik
> Fix For: 0.22.0
>
> Attachments: HDFS-1006-BP20.patch, hdfs-1006-bugfix-1.patch, HDFS-1006-trunk.patch, HDFS-1006-Y20.1.patch, HDFS-1006-Y20.patch
>
>
> should use https:// and port 50475
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HDFS-1006) getImage/putImage http requests should
be https for the case of security enabled.
Posted by "Jakob Homan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1006?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jakob Homan updated HDFS-1006:
------------------------------
Attachment: HDFS-1006-Y20.patch
New patch for Y20 branch, not to be committed.
> getImage/putImage http requests should be https for the case of security enabled.
> ---------------------------------------------------------------------------------
>
> Key: HDFS-1006
> URL: https://issues.apache.org/jira/browse/HDFS-1006
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Boris Shkolnik
> Assignee: Boris Shkolnik
> Attachments: HDFS-1006-BP20.patch, HDFS-1006-Y20.patch
>
>
> should use https:// and port 50475
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HDFS-1006) getImage/putImage http requests should
be https for the case of security enabled.
Posted by "Jakob Homan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1006?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jakob Homan updated HDFS-1006:
------------------------------
Attachment: HDFS-1006-trunk-2.patch
Updated patch for Devaraj's comments. Now throw an exception if using wildcard addr with security, although once we have a unit testing framework for Kerberos - please, please, please - we'll need to come up with a good way of dealing with this.
> getImage/putImage http requests should be https for the case of security enabled.
> ---------------------------------------------------------------------------------
>
> Key: HDFS-1006
> URL: https://issues.apache.org/jira/browse/HDFS-1006
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Boris Shkolnik
> Assignee: Boris Shkolnik
> Fix For: 0.22.0
>
> Attachments: HDFS-1006-BP20.patch, hdfs-1006-bugfix-1.patch, HDFS-1006-trunk-2.patch, HDFS-1006-trunk.patch, HDFS-1006-Y20.1.patch, HDFS-1006-Y20.patch
>
>
> should use https:// and port 50475
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-1006) getImage/putImage http requests
should be https for the case of security enabled.
Posted by "Jakob Homan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12886569#action_12886569 ]
Jakob Homan commented on HDFS-1006:
-----------------------------------
Test failures are unrelated and have been on-going, such as in HDFS-1005 : http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/210/testReport
> getImage/putImage http requests should be https for the case of security enabled.
> ---------------------------------------------------------------------------------
>
> Key: HDFS-1006
> URL: https://issues.apache.org/jira/browse/HDFS-1006
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Boris Shkolnik
> Assignee: Boris Shkolnik
> Fix For: 0.22.0
>
> Attachments: HDFS-1006-BP20.patch, hdfs-1006-bugfix-1.patch, HDFS-1006-trunk-2.patch, HDFS-1006-trunk.patch, HDFS-1006-Y20.1.patch, HDFS-1006-Y20.patch
>
>
> should use https:// and port 50475
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HDFS-1006) getImage/putImage http requests should
be https for the case of security enabled.
Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1006?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Devaraj Das updated HDFS-1006:
------------------------------
Attachment: HDFS-1006-Y20.1.patch
Minor updates to the previous patch.
> getImage/putImage http requests should be https for the case of security enabled.
> ---------------------------------------------------------------------------------
>
> Key: HDFS-1006
> URL: https://issues.apache.org/jira/browse/HDFS-1006
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Boris Shkolnik
> Assignee: Boris Shkolnik
> Attachments: HDFS-1006-BP20.patch, HDFS-1006-Y20.1.patch, HDFS-1006-Y20.patch
>
>
> should use https:// and port 50475
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-1006) getImage/putImage http requests
should be https for the case of security enabled.
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12886566#action_12886566 ]
Hadoop QA commented on HDFS-1006:
---------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12449009/HDFS-1006-trunk-2.patch
against trunk revision 961495.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed core unit tests.
-1 contrib tests. The patch failed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/426/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/426/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/426/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/426/console
This message is automatically generated.
> getImage/putImage http requests should be https for the case of security enabled.
> ---------------------------------------------------------------------------------
>
> Key: HDFS-1006
> URL: https://issues.apache.org/jira/browse/HDFS-1006
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Boris Shkolnik
> Assignee: Boris Shkolnik
> Fix For: 0.22.0
>
> Attachments: HDFS-1006-BP20.patch, hdfs-1006-bugfix-1.patch, HDFS-1006-trunk-2.patch, HDFS-1006-trunk.patch, HDFS-1006-Y20.1.patch, HDFS-1006-Y20.patch
>
>
> should use https:// and port 50475
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HDFS-1006) getImage/putImage http requests should
be https for the case of security enabled.
Posted by "Jakob Homan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1006?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jakob Homan updated HDFS-1006:
------------------------------
Status: Open (was: Patch Available)
> getImage/putImage http requests should be https for the case of security enabled.
> ---------------------------------------------------------------------------------
>
> Key: HDFS-1006
> URL: https://issues.apache.org/jira/browse/HDFS-1006
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Boris Shkolnik
> Assignee: Boris Shkolnik
> Fix For: 0.22.0
>
> Attachments: HDFS-1006-BP20.patch, hdfs-1006-bugfix-1.patch, HDFS-1006-trunk-2.patch, HDFS-1006-trunk.patch, HDFS-1006-Y20.1.patch, HDFS-1006-Y20.patch
>
>
> should use https:// and port 50475
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HDFS-1006) getImage/putImage http requests should
be https for the case of security enabled.
Posted by "Boris Shkolnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1006?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Boris Shkolnik updated HDFS-1006:
---------------------------------
Attachment: HDFS-1006-BP20.patch
for previous version of hadoop. Not for commit.
> getImage/putImage http requests should be https for the case of security enabled.
> ---------------------------------------------------------------------------------
>
> Key: HDFS-1006
> URL: https://issues.apache.org/jira/browse/HDFS-1006
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Boris Shkolnik
> Attachments: HDFS-1006-BP20.patch
>
>
> should use https:// and port 50475
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.