You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/05/28 07:11:12 UTC
[GitHub] [flink] zhijiangW opened a new pull request #12374: [FLINK-17992][checkpointing] Exception from RemoteInputChannel#onBuffer should not fail the whole NetworkClientHandler
zhijiangW opened a new pull request #12374:
URL: https://github.com/apache/flink/pull/12374
## What is the purpose of the change
RemoteInputChannel#onBuffer is invoked by CreditBasedPartitionRequestClientHandler while receiving and decoding the network data. #onBuffer can throw exceptions which would tag the error in client handler and fail all the added input channels inside handler. Then it would cause a tricky potential issue as following.
If the RemoteInputChannel is canceling by canceler thread, then the task thread might exit early than canceler thread terminate. That means the PartitionRequestClient might not be closed (triggered by canceler thread) while the new task attempt is already deployed into the same TaskManager. Therefore the new task might reuse the previous PartitionRequestClient while requesting partitions, but note that the respective client handler was already tagged an error before during above RemoteInputChannel#onBuffer, to cause the next round unnecessary failover.
The solution is to only fail the respective task when its internal RemoteInputChannel#onBuffer throws any exceptions instead of failing the whole channels inside client handler, then the client is still healthy and can also be reused by other input channels as long as it is not released yet.
## Brief change log
- *Not fail the whole network client handler while exception in `RemoteInputChannel#onBuffer*
## Verifying this change
Added new unit test `CreditBasedPartitionRequestClientHandlerTest#testRemoteInputChannelOnBufferException`
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zhijiangW merged pull request #12374: [FLINK-17992][checkpointing] Exception from RemoteInputChannel#onBuffer should not fail the whole NetworkClientHandler
Posted by GitBox <gi...@apache.org>.
zhijiangW merged pull request #12374:
URL: https://github.com/apache/flink/pull/12374
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12374: [FLINK-17992][checkpointing] Exception from RemoteInputChannel#onBuffer should not fail the whole NetworkClientHandler
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12374:
URL: https://github.com/apache/flink/pull/12374#issuecomment-635171486
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "eeaa680286b6dd389acebbf1d8695ba94ff5ec59",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2341",
"triggerID" : "eeaa680286b6dd389acebbf1d8695ba94ff5ec59",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* eeaa680286b6dd389acebbf1d8695ba94ff5ec59 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2341)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12374: [FLINK-17992][checkpointing] Exception from RemoteInputChannel#onBuffer should not fail the whole NetworkClientHandler
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12374:
URL: https://github.com/apache/flink/pull/12374#issuecomment-635171486
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "eeaa680286b6dd389acebbf1d8695ba94ff5ec59",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2341",
"triggerID" : "eeaa680286b6dd389acebbf1d8695ba94ff5ec59",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* eeaa680286b6dd389acebbf1d8695ba94ff5ec59 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2341)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12374: [FLINK-17992][checkpointing] Exception from RemoteInputChannel#onBuffer should not fail the whole NetworkClientHandler
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12374:
URL: https://github.com/apache/flink/pull/12374#issuecomment-635171486
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "eeaa680286b6dd389acebbf1d8695ba94ff5ec59",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2341",
"triggerID" : "eeaa680286b6dd389acebbf1d8695ba94ff5ec59",
"triggerType" : "PUSH"
}, {
"hash" : "a4a4f7c5d2e2db50eda956b89b6b38e0f0c2e0b3",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2361",
"triggerID" : "a4a4f7c5d2e2db50eda956b89b6b38e0f0c2e0b3",
"triggerType" : "PUSH"
}, {
"hash" : "59ce42b5686283f5eb3b0118c66d24dda2c0096a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "59ce42b5686283f5eb3b0118c66d24dda2c0096a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a4a4f7c5d2e2db50eda956b89b6b38e0f0c2e0b3 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2361)
* 59ce42b5686283f5eb3b0118c66d24dda2c0096a UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12374: [FLINK-17992][checkpointing] Exception from RemoteInputChannel#onBuffer should not fail the whole NetworkClientHandler
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12374:
URL: https://github.com/apache/flink/pull/12374#issuecomment-635160458
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit eeaa680286b6dd389acebbf1d8695ba94ff5ec59 (Thu May 28 07:23:19 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12374: [FLINK-17992][checkpointing] Exception from RemoteInputChannel#onBuffer should not fail the whole NetworkClientHandler
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12374:
URL: https://github.com/apache/flink/pull/12374#issuecomment-635171486
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "eeaa680286b6dd389acebbf1d8695ba94ff5ec59",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2341",
"triggerID" : "eeaa680286b6dd389acebbf1d8695ba94ff5ec59",
"triggerType" : "PUSH"
}, {
"hash" : "a4a4f7c5d2e2db50eda956b89b6b38e0f0c2e0b3",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2361",
"triggerID" : "a4a4f7c5d2e2db50eda956b89b6b38e0f0c2e0b3",
"triggerType" : "PUSH"
}, {
"hash" : "59ce42b5686283f5eb3b0118c66d24dda2c0096a",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2418",
"triggerID" : "59ce42b5686283f5eb3b0118c66d24dda2c0096a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a4a4f7c5d2e2db50eda956b89b6b38e0f0c2e0b3 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2361)
* 59ce42b5686283f5eb3b0118c66d24dda2c0096a Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2418)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zhijiangW edited a comment on pull request #12374: [FLINK-17992][checkpointing] Exception from RemoteInputChannel#onBuffer should not fail the whole NetworkClientHandler
Posted by GitBox <gi...@apache.org>.
zhijiangW edited a comment on pull request #12374:
URL: https://github.com/apache/flink/pull/12374#issuecomment-635723903
Thanks for review @pnowojski and @Jiayi-Liao ! I addressed the method rename issue, will merge after azure green.
> supper nitty nit: I think it is touching the performance sensitive code (per buffer path) :) I'm pretty sure it doesn't affect performance, but it's touching them.
**The runtime per-record code paths (performance sensitive): (yes / no / don't know)**, maybe we should adjust the template as `per-record` or `per-buffer`. :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12374: [FLINK-17992][checkpointing] Exception from RemoteInputChannel#onBuffer should not fail the whole NetworkClientHandler
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12374:
URL: https://github.com/apache/flink/pull/12374#issuecomment-635171486
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "eeaa680286b6dd389acebbf1d8695ba94ff5ec59",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2341",
"triggerID" : "eeaa680286b6dd389acebbf1d8695ba94ff5ec59",
"triggerType" : "PUSH"
}, {
"hash" : "a4a4f7c5d2e2db50eda956b89b6b38e0f0c2e0b3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2361",
"triggerID" : "a4a4f7c5d2e2db50eda956b89b6b38e0f0c2e0b3",
"triggerType" : "PUSH"
}, {
"hash" : "59ce42b5686283f5eb3b0118c66d24dda2c0096a",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2418",
"triggerID" : "59ce42b5686283f5eb3b0118c66d24dda2c0096a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 59ce42b5686283f5eb3b0118c66d24dda2c0096a Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2418)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12374: [FLINK-17992][checkpointing] Exception from RemoteInputChannel#onBuffer should not fail the whole NetworkClientHandler
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12374:
URL: https://github.com/apache/flink/pull/12374#issuecomment-635171486
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "eeaa680286b6dd389acebbf1d8695ba94ff5ec59",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "eeaa680286b6dd389acebbf1d8695ba94ff5ec59",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* eeaa680286b6dd389acebbf1d8695ba94ff5ec59 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zhijiangW commented on pull request #12374: [FLINK-17992][checkpointing] Exception from RemoteInputChannel#onBuffer should not fail the whole NetworkClientHandler
Posted by GitBox <gi...@apache.org>.
zhijiangW commented on pull request #12374:
URL: https://github.com/apache/flink/pull/12374#issuecomment-635723903
Thanks for review @pnowojski and @Jiayi-Liao ! I addressed the method rename issue, will merge after azure green.
> supper nitty nit: I think it is touching the performance sensitive code (per buffer path) :) I'm pretty sure it doesn't affect performance, but it's touching them.
'The runtime per-record code paths (performance sensitive): (yes / no / don't know)', maybe we should adjust the template as `per-record` or `per-buffer`. :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org