You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/04/27 16:48:07 UTC

[GitHub] [arrow-datafusion] jorgecarleitao commented on pull request #55: Support qualified columns in queries

jorgecarleitao commented on pull request #55:
URL: https://github.com/apache/arrow-datafusion/pull/55#issuecomment-827755259


   So, having done this type of exercises before in DataFusion, I tend to agree that these things are really difficult to divide in smaller PRs, as they touch delicate balances in the code.
   
   I agree that the current way we handle names has reached its limits, and thus I am super happy to see this PR.
   
   wrt to the invariants, I do think that we should be able to address them here. I am still trying to understand why we need to break invariants to enable qualified column names. This is the gist of my comment: are these changes by design, a theoretical impediment whereby we can't have both qualified names and the invariants, or derived from this still being work in progress?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org