[GitHub] [bookkeeper] lifepuzzlefun commented on a diff in pull request #3876: Try to use jdk api to create hardlink when rename file when compaction.

["lifepuzzlefun (via GitHub)" <gi...@apache.org>]

lifepuzzlefun commented on code in PR #3876:
URL: https://github.com/apache/bookkeeper/pull/3876#discussion_r1145720608


##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/util/HardLink.java:
##########
@@ -416,6 +471,19 @@ public static void createHardLink(File file, File linkName)
       throw new IOException(
           "invalid arguments to createHardLink: link name is null");
     }
+
+    // if createLink available try first, else fall back to shell command.
+    if (CREATE_LINK_SUPPORTED.get()) {

Review Comment:
   fixed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org