[GitHub] [incubator-streampark] tisonkun commented on a diff in pull request #2353: [Fix] Test classes should be under sp package

["tisonkun (via GitHub)" <gi...@apache.org>]

tisonkun commented on code in PR #2353:
URL: https://github.com/apache/incubator-streampark/pull/2353#discussion_r1113835790


##########
streampark-console/streampark-console-service/src/test/java/org/apache/streampark/common/util/RegexTest.java:
##########
@@ -28,6 +26,8 @@
 import java.util.ArrayList;
 import java.util.Collections;
 import java.util.List;
+import java.util.regex.Matcher;
+import java.util.regex.Pattern;
 import java.util.stream.Collectors;
 
 class RegexTest {

Review Comment:
   BTW, `RegexTest#classLoader` and `RegexTest#flinkVersion` seem quite tricky and fail locally. How can we verify these tests correctly?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org