You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@clerezza.apache.org by "Reto Bachmann-Gmür (JIRA)" <ji...@apache.org> on 2010/01/11 17:02:54 UTC
[jira] Created: (CLEREZZA-70) Content / Discobits editor:
properties get losts on saving
Content / Discobits editor: properties get losts on saving
----------------------------------------------------------
Key: CLEREZZA-70
URL: https://issues.apache.org/jira/browse/CLEREZZA-70
Project: Clerezza
Issue Type: Bug
Reporter: Reto Bachmann-Gmür
Assignee: Reto Bachmann-Gmür
Since we remove the whole context of the node before witing the new data, the triples embbedding a conten in its container get lost
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CLEREZZA-70) Content / Discobits editor:
properties get losts on saving
Posted by "Hasan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CLEREZZA-70?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12804495#action_12804495 ]
Hasan commented on CLEREZZA-70:
-------------------------------
MGraphUtils
- wrong copyright notice
- lines 75-77 are not needed
if (subject instanceof BNode) {
subject = null;
}
- line 101 maybe wrong: getSubject() to be used instead of getObject()
- line 113 requires implementation of graph isomorphism
afaik this is not yet supported
- suggest to lock the mgraph before removing triples in line 124
- missing test
> Content / Discobits editor: properties get losts on saving
> ----------------------------------------------------------
>
> Key: CLEREZZA-70
> URL: https://issues.apache.org/jira/browse/CLEREZZA-70
> Project: Clerezza
> Issue Type: Bug
> Reporter: Reto Bachmann-Gmür
> Assignee: Reto Bachmann-Gmür
>
> Since we remove the whole context of the node before witing the new data, the triples embbedding a conten in its container get lost
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CLEREZZA-70) Content / Discobits editor:
properties get losts on saving
Posted by "Hasan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CLEREZZA-70?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12805429#action_12805429 ]
Hasan commented on CLEREZZA-70:
-------------------------------
reviewing
> Content / Discobits editor: properties get losts on saving
> ----------------------------------------------------------
>
> Key: CLEREZZA-70
> URL: https://issues.apache.org/jira/browse/CLEREZZA-70
> Project: Clerezza
> Issue Type: Bug
> Reporter: Reto Bachmann-Gmür
> Assignee: Reto Bachmann-Gmür
>
> Since we remove the whole context of the node before witing the new data, the triples embbedding a conten in its container get lost
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (CLEREZZA-70) Content / Discobits editor: properties
get losts on saving
Posted by "Reto Bachmann-Gmür (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CLEREZZA-70?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Reto Bachmann-Gmür closed CLEREZZA-70.
--------------------------------------
> Content / Discobits editor: properties get losts on saving
> ----------------------------------------------------------
>
> Key: CLEREZZA-70
> URL: https://issues.apache.org/jira/browse/CLEREZZA-70
> Project: Clerezza
> Issue Type: Bug
> Reporter: Reto Bachmann-Gmür
> Assignee: Reto Bachmann-Gmür
>
> Since we remove the whole context of the node before witing the new data, the triples embbedding a conten in its container get lost
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (CLEREZZA-70) Content / Discobits editor:
properties get losts on saving
Posted by "Reto Bachmann-Gmür (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CLEREZZA-70?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Reto Bachmann-Gmür resolved CLEREZZA-70.
----------------------------------------
Resolution: Fixed
> Content / Discobits editor: properties get losts on saving
> ----------------------------------------------------------
>
> Key: CLEREZZA-70
> URL: https://issues.apache.org/jira/browse/CLEREZZA-70
> Project: Clerezza
> Issue Type: Bug
> Reporter: Reto Bachmann-Gmür
> Assignee: Reto Bachmann-Gmür
>
> Since we remove the whole context of the node before witing the new data, the triples embbedding a conten in its container get lost
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (CLEREZZA-70) Content / Discobits editor:
properties get losts on saving
Posted by "Reto Bachmann-Gmür (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CLEREZZA-70?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Reto Bachmann-Gmür resolved CLEREZZA-70.
----------------------------------------
Resolution: Fixed
> Content / Discobits editor: properties get losts on saving
> ----------------------------------------------------------
>
> Key: CLEREZZA-70
> URL: https://issues.apache.org/jira/browse/CLEREZZA-70
> Project: Clerezza
> Issue Type: Bug
> Reporter: Reto Bachmann-Gmür
> Assignee: Reto Bachmann-Gmür
>
> Since we remove the whole context of the node before witing the new data, the triples embbedding a conten in its container get lost
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (CLEREZZA-70) Content / Discobits editor:
properties get losts on saving
Posted by "Hasan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CLEREZZA-70?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hasan reopened CLEREZZA-70:
---------------------------
> Content / Discobits editor: properties get losts on saving
> ----------------------------------------------------------
>
> Key: CLEREZZA-70
> URL: https://issues.apache.org/jira/browse/CLEREZZA-70
> Project: Clerezza
> Issue Type: Bug
> Reporter: Reto Bachmann-Gmür
> Assignee: Reto Bachmann-Gmür
>
> Since we remove the whole context of the node before witing the new data, the triples embbedding a conten in its container get lost
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CLEREZZA-70) Content / Discobits editor:
properties get losts on saving
Posted by "Reto Bachmann-Gmür (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CLEREZZA-70?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12804596#action_12804596 ]
Reto Bachmann-Gmür commented on CLEREZZA-70:
--------------------------------------------
just locking before and after the addAll invocation has no effect at all, starting the lock before the revoke could prevent some unindented effect on concurrent saving operations but I can't see any serious danger in such an unlikely event to justify the price in performance (graph isomorphism operations would have to be done within the writelock, so if we'd really need that locking we would better split the removeSubGraph method in two, so that the locking can be reduced to the actual removing and the addition).
> Content / Discobits editor: properties get losts on saving
> ----------------------------------------------------------
>
> Key: CLEREZZA-70
> URL: https://issues.apache.org/jira/browse/CLEREZZA-70
> Project: Clerezza
> Issue Type: Bug
> Reporter: Reto Bachmann-Gmür
> Assignee: Reto Bachmann-Gmür
>
> Since we remove the whole context of the node before witing the new data, the triples embbedding a conten in its container get lost
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CLEREZZA-70) Content / Discobits editor:
properties get losts on saving
Posted by "Hasan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CLEREZZA-70?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12804457#action_12804457 ]
Hasan commented on CLEREZZA-70:
-------------------------------
reviewing
> Content / Discobits editor: properties get losts on saving
> ----------------------------------------------------------
>
> Key: CLEREZZA-70
> URL: https://issues.apache.org/jira/browse/CLEREZZA-70
> Project: Clerezza
> Issue Type: Bug
> Reporter: Reto Bachmann-Gmür
> Assignee: Reto Bachmann-Gmür
>
> Since we remove the whole context of the node before witing the new data, the triples embbedding a conten in its container get lost
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CLEREZZA-70) Content / Discobits editor:
properties get losts on saving
Posted by "Hasan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CLEREZZA-70?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12804507#action_12804507 ]
Hasan commented on CLEREZZA-70:
-------------------------------
Editor.java
- suggest to use java annotation instead of javadoc annotation for service component declaration and references
In postDiscoBit
- missing javadoc
- query param resource unused, suggest to remove (also in tria-disco.js)
- suggest to lock mgraph before adding triples
> Content / Discobits editor: properties get losts on saving
> ----------------------------------------------------------
>
> Key: CLEREZZA-70
> URL: https://issues.apache.org/jira/browse/CLEREZZA-70
> Project: Clerezza
> Issue Type: Bug
> Reporter: Reto Bachmann-Gmür
> Assignee: Reto Bachmann-Gmür
>
> Since we remove the whole context of the node before witing the new data, the triples embbedding a conten in its container get lost
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.