You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2016/12/02 06:43:00 UTC
Review Request 54294: Added an I/O switchboard test with TTY enabled.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54294/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Kevin Klues.
Repository: mesos
Description
-------
Added an I/O switchboard test with TTY enabled.
Diffs
-----
src/tests/containerizer/io_switchboard_tests.cpp d82f22b5c9a8d177577db3aeaae9e571e7e2fb80
Diff: https://reviews.apache.org/r/54294/diff/
Testing
-------
make check
Thanks,
Jie Yu
Re: Review Request 54294: Added an I/O switchboard test with TTY
enabled.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54294/
-----------------------------------------------------------
(Updated Dec. 5, 2016, 5:38 a.m.)
Review request for mesos, Benjamin Hindman and Kevin Klues.
Changes
-------
Rebased. Addressed comments.
Bugs: MESOS-6470
https://issues.apache.org/jira/browse/MESOS-6470
Repository: mesos
Description
-------
Added an I/O switchboard test with TTY enabled.
Diffs (updated)
-----
src/tests/containerizer/io_switchboard_tests.cpp d82f22b5c9a8d177577db3aeaae9e571e7e2fb80
Diff: https://reviews.apache.org/r/54294/diff/
Testing
-------
make check
Thanks,
Jie Yu
Re: Review Request 54294: Added an I/O switchboard test with TTY
enabled.
Posted by Kevin Klues <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54294/#review157960
-----------------------------------------------------------
Ship it!
Ship It!
- Kevin Klues
On Dec. 5, 2016, 12:17 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54294/
> -----------------------------------------------------------
>
> (Updated Dec. 5, 2016, 12:17 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Kevin Klues.
>
>
> Bugs: MESOS-6470
> https://issues.apache.org/jira/browse/MESOS-6470
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added an I/O switchboard test with TTY enabled.
>
>
> Diffs
> -----
>
> src/tests/containerizer/io_switchboard_tests.cpp d82f22b5c9a8d177577db3aeaae9e571e7e2fb80
>
> Diff: https://reviews.apache.org/r/54294/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 54294: Added an I/O switchboard test with TTY
enabled.
Posted by Jie Yu <yu...@gmail.com>.
> On Dec. 5, 2016, 2:10 a.m., Kevin Klues wrote:
> > src/tests/containerizer/io_switchboard_tests.cpp, lines 308-309
> > <https://reviews.apache.org/r/54294/diff/2/?file=1576052#file1576052line308>
> >
> > Why not put this at the top with the other declaration for `IOSwitchboardServerTest`?
We typically put fixture close to its tests.
- Jie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54294/#review157939
-----------------------------------------------------------
On Dec. 5, 2016, 12:17 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54294/
> -----------------------------------------------------------
>
> (Updated Dec. 5, 2016, 12:17 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Kevin Klues.
>
>
> Bugs: MESOS-6470
> https://issues.apache.org/jira/browse/MESOS-6470
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added an I/O switchboard test with TTY enabled.
>
>
> Diffs
> -----
>
> src/tests/containerizer/io_switchboard_tests.cpp d82f22b5c9a8d177577db3aeaae9e571e7e2fb80
>
> Diff: https://reviews.apache.org/r/54294/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 54294: Added an I/O switchboard test with TTY
enabled.
Posted by Kevin Klues <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54294/#review157939
-----------------------------------------------------------
src/tests/containerizer/io_switchboard_tests.cpp (lines 307 - 308)
<https://reviews.apache.org/r/54294/#comment228616>
Why not put this at the top with the other declaration for `IOSwitchboardServerTest`?
src/tests/containerizer/io_switchboard_tests.cpp (line 344)
<https://reviews.apache.org/r/54294/#comment228617>
Can you add a quick comment about what's going on here (and why it's important for testing the tty redirection).
- Kevin Klues
On Dec. 5, 2016, 12:17 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54294/
> -----------------------------------------------------------
>
> (Updated Dec. 5, 2016, 12:17 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Kevin Klues.
>
>
> Bugs: MESOS-6470
> https://issues.apache.org/jira/browse/MESOS-6470
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added an I/O switchboard test with TTY enabled.
>
>
> Diffs
> -----
>
> src/tests/containerizer/io_switchboard_tests.cpp d82f22b5c9a8d177577db3aeaae9e571e7e2fb80
>
> Diff: https://reviews.apache.org/r/54294/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 54294: Added an I/O switchboard test with TTY
enabled.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54294/
-----------------------------------------------------------
(Updated Dec. 5, 2016, 12:17 a.m.)
Review request for mesos, Benjamin Hindman and Kevin Klues.
Bugs: MESOS-6470
https://issues.apache.org/jira/browse/MESOS-6470
Repository: mesos
Description
-------
Added an I/O switchboard test with TTY enabled.
Diffs (updated)
-----
src/tests/containerizer/io_switchboard_tests.cpp d82f22b5c9a8d177577db3aeaae9e571e7e2fb80
Diff: https://reviews.apache.org/r/54294/diff/
Testing
-------
make check
Thanks,
Jie Yu
Re: Review Request 54294: Added an I/O switchboard test with TTY
enabled.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54294/
-----------------------------------------------------------
(Updated Dec. 2, 2016, 6:30 p.m.)
Review request for mesos, Benjamin Hindman and Kevin Klues.
Bugs: MESOS-6470
https://issues.apache.org/jira/browse/MESOS-6470
Repository: mesos
Description
-------
Added an I/O switchboard test with TTY enabled.
Diffs
-----
src/tests/containerizer/io_switchboard_tests.cpp d82f22b5c9a8d177577db3aeaae9e571e7e2fb80
Diff: https://reviews.apache.org/r/54294/diff/
Testing
-------
make check
Thanks,
Jie Yu