[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #209: [FLINK-27103] Don't store redundant primary key fields

[GitBox <gi...@apache.org>]

JingsongLi commented on code in PR #209:
URL: https://github.com/apache/flink-table-store/pull/209#discussion_r918515556


##########
flink-table-store-core/src/main/java/org/apache/flink/table/store/file/KeyValueSerializer.java:
##########
@@ -45,6 +49,13 @@ public class KeyValueSerializer extends ObjectSerializer<KeyValue> {
     private final OffsetRowData reusedValue;
     private final KeyValue reusedKv;
 
+    private TableSchema tableSchema;
+
+    public KeyValueSerializer(RowType keyType, RowType valueType, TableSchema tableSchema) {

Review Comment:
   I think we can introduce a special deserializer for `ColumnarRowIterator`.
   After getting `VectorizedColumnBatch` from `ColumnarRowData`. We can get `ColumnVector[]`. Then, we can do our projection to produce key and value for `KeyValue`. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org