[GitHub] [incubator-celeborn] zhongqiangczq commented on a diff in pull request #1270: [CELEBORN-335][FLINK] Fix memory leak.

["zhongqiangczq (via GitHub)" <gi...@apache.org>]

zhongqiangczq commented on code in PR #1270:
URL: https://github.com/apache/incubator-celeborn/pull/1270#discussion_r1116781258


##########
client-flink/common/src/main/java/org/apache/celeborn/plugin/flink/network/TransportFrameDecoderWithBufferSupplier.java:
##########
@@ -144,6 +148,9 @@ public void channelRead(ChannelHandlerContext ctx, Object data) {
           }
         }
       }
+    } catch (Exception e) {
+      logger.error(
+          "decode msg failed type {} curMsg {} size {}", curType, curMsg, nettyBuf.readableBytes());

Review Comment:
   logger.error("", nettyBuf.readableBytes() => logger.error("", nettyBuf.readableBytes(),e)?, we can see the exception cause



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org