You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "aliehsaeedii (via GitHub)" <gi...@apache.org> on 2026/04/29 08:08:42 UTC
[PR] MINOR: Fix duplicate args in KStreamSessionWindowAggregateProcessorTest [kafka]
aliehsaeedii opened a new pull request, #22183:
URL: https://github.com/apache/kafka/pull/22183
The `emitStrategyAndHeadersMatrix()` currently returns four entries but they are duplicates of ON_WINDOW_UPDATE (and therefore also runs each case twice). This also drops coverage for EmitStrategy.StrategyType.ON_WINDOW_CLOSE, which was previously covered via @EnumSource. Update the method source to generate the full matrix of strategy type(s) and withHeaders values (eg, include both ON_WINDOW_UPDATE and ON_WINDOW_CLOSE, each with withHeaders=false/true) without duplicates.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Fix duplicate args in KStreamSessionWindowAggregateProcessorTest [kafka]
Posted by "mjsax (via GitHub)" <gi...@apache.org>.
mjsax commented on PR #22183:
URL: https://github.com/apache/kafka/pull/22183#issuecomment-4349537361
Thanks for the fix. Merged to `trunk`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Fix duplicate args in KStreamSessionWindowAggregateProcessorTest [kafka]
Posted by "mjsax (via GitHub)" <gi...@apache.org>.
mjsax merged PR #22183:
URL: https://github.com/apache/kafka/pull/22183
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org