You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/09/09 08:45:51 UTC
[GitHub] [dolphinscheduler] LiuBodong opened a new issue, #11884: [Bug] [UI] allow-input check on some input element are unnecessary
LiuBodong opened a new issue, #11884:
URL: https://github.com/apache/dolphinscheduler/issues/11884
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
User could not type `WHITESPACE` into environment and password.
## Why this happends
`allow-input` attribute was added to NInput tag element in this issue #10845. and was merged by #10984 and #10975.
This causes some `textarea` and `password ` input element could not add whitespace at the end of content. But normally, users are able to add whitespace to those content.
## What should we do
In my opinion, we should remove those verification on textaera and password element.
### What you expected to happen
User can write what they want into textarea and password
### How to reproduce
* Start api service and ui
* Click security -> environment manage
* Click `add environment ` button and type `export JAVA_HOME=xxx` into the `Environment Config` slot
then you will see that you cant type ` ` (whitespace) after `export`
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] closed issue #11884: [Bug] [UI] allow-input check on some input element are unnecessary
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed issue #11884: [Bug] [UI] allow-input check on some input element are unnecessary
URL: https://github.com/apache/dolphinscheduler/issues/11884
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #11884: [Bug] [UI] allow-input check on some input element are unnecessary
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #11884:
URL: https://github.com/apache/dolphinscheduler/issues/11884#issuecomment-1241756327
Thank you for your feedback, we have received your issue, Please wait patiently for a reply.
* In order for us to understand your request as soon as possible, please provide detailed information、version or pictures.
* If you haven't received a reply for a long time, you can [join our slack](https://s.apache.org/dolphinscheduler-slack) and send your question to channel `#troubleshooting`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #11884: [Bug] [UI] allow-input check on some input element are unnecessary
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #11884:
URL: https://github.com/apache/dolphinscheduler/issues/11884#issuecomment-1287961173
This issue has been closed because it has not received response for too long time. You could reopen it if you encountered similar problems in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #11884: [Bug] [UI] allow-input check on some input element are unnecessary
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #11884:
URL: https://github.com/apache/dolphinscheduler/issues/11884#issuecomment-1279859472
This issue has been automatically marked as stale because it has not had recent activity for 30 days. It will be closed in next 7 days if no further activity occurs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] LiuBodong commented on issue #11884: [Bug] [UI] allow-input check on some input element are unnecessary
Posted by GitBox <gi...@apache.org>.
LiuBodong commented on issue #11884:
URL: https://github.com/apache/dolphinscheduler/issues/11884#issuecomment-1247851095
I'm not meaning to remove `all` the verification on input, But I think some unnecessary verification could be removed.
For example: `Envrionment Config`, the verification prevent type such shell command: `export JAVA_HOME=/usr/lib/jvm/default`.
By the way, show `password` contains whitespace?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] Amy0104 commented on issue #11884: [Bug] [UI] allow-input check on some input element are unnecessary
Posted by GitBox <gi...@apache.org>.
Amy0104 commented on issue #11884:
URL: https://github.com/apache/dolphinscheduler/issues/11884#issuecomment-1244931732
I think so. This's not a bug. Removing whitespace from both ends of a string is to prevent user misuse.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] caishunfeng commented on issue #11884: [Bug] [UI] allow-input check on some input element are unnecessary
Posted by GitBox <gi...@apache.org>.
caishunfeng commented on issue #11884:
URL: https://github.com/apache/dolphinscheduler/issues/11884#issuecomment-1244821208
I don't think it's a bug and we should not make the input element allow whitespace at the end of content.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org