You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@wicket.apache.org by Doug Donohoe <do...@donohoe.info> on 2008/06/01 21:14:30 UTC

igor - bug in recent change?

In BookmarkablePageRequestTarget line 292

   for (Entry&lt;String, Object> entry : pageParameters.entrySet())
   {
       final Object value = entry.getValue();
*      if (value.getClass().isArray())
       [...]
   }

I'm getting a NPE.  Values can be null in PageParameters, so you should
check null here.

This code was added on 5/26/2008.

-Doug
-- 
View this message in context: http://www.nabble.com/igor---bug-in-recent-change--tp17589000p17589000.html
Sent from the Wicket - Dev mailing list archive at Nabble.com.

Re: igor - bug in recent change?

Posted by Igor Vaynberg <ig...@gmail.com>.

thanks, should be fixed in trunk

-igor

On Sun, Jun 1, 2008 at 12:28 PM, Doug Donohoe <do...@donohoe.info> wrote:
>
> I created https://issues.apache.org/jira/browse/WICKET-1676 and submitted a
> patch, along with another bug I found in this class (a ctor wasn't passing a
> pagemap param - that one found thanks to my IDE).
>
> -Doug
>
>
> Doug Donohoe wrote:
>>
>> In BookmarkablePageRequestTarget line 292
>>
>>    for (Entry&lt;String, Object> entry : pageParameters.entrySet())
>>    {
>>        final Object value = entry.getValue();
>> *      if (value.getClass().isArray())
>>        [...]
>>    }
>>
>> I'm getting a NPE.  Values can be null in PageParameters, so you should
>> check null here.
>>
>> This code was added on 5/26/2008.
>>
>> -Doug
>>
>
> --
> View this message in context: http://www.nabble.com/igor---bug-in-recent-change--tp17589000p17589130.html
> Sent from the Wicket - Dev mailing list archive at Nabble.com.
>
>

Re: igor - bug in recent change?

Posted by Doug Donohoe <do...@donohoe.info>.

I created https://issues.apache.org/jira/browse/WICKET-1676 and submitted a
patch, along with another bug I found in this class (a ctor wasn't passing a
pagemap param - that one found thanks to my IDE).

-Doug


Doug Donohoe wrote:
> 
> In BookmarkablePageRequestTarget line 292
> 
>    for (Entry&lt;String, Object> entry : pageParameters.entrySet())
>    {
>        final Object value = entry.getValue();
> *      if (value.getClass().isArray())
>        [...]
>    }
> 
> I'm getting a NPE.  Values can be null in PageParameters, so you should
> check null here.
> 
> This code was added on 5/26/2008.
> 
> -Doug
> 

-- 
View this message in context: http://www.nabble.com/igor---bug-in-recent-change--tp17589000p17589130.html
Sent from the Wicket - Dev mailing list archive at Nabble.com.