You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/11/05 05:09:10 UTC
[GitHub] [incubator-tvm] euntaik opened a new pull request #6855: [TVMC] use target_host when it is set
euntaik opened a new pull request #6855:
URL: https://github.com/apache/incubator-tvm/pull/6855
Feed target_host to the relay.build when it is provided.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] comaniac commented on a change in pull request #6855: [TVMC] use target_host when it is set
Posted by GitBox <gi...@apache.org>.
comaniac commented on a change in pull request #6855:
URL: https://github.com/apache/incubator-tvm/pull/6855#discussion_r527859587
##########
File path: tests/python/driver/tvmc/test_compiler.py
##########
@@ -150,3 +150,21 @@ def test_cross_compile_aarch64_onnx_module(onnx_resnet50):
assert type(params) is dict
assert type(dumps) is dict
assert "asm" in dumps.keys()
+
+
+@tvm.testing.requires_opencl
+def test_compile_opencl(tflite_mobilenet_v1_0_25_128):
+ pytest.importorskip("tflite")
+
+ graph, lib, params, dumps = tvmc.compiler.compile_model(
+ tflite_mobilenet_v1_0_25_128,
+ target="opencl",
+ target_host="llvm",
+ alter_layout="NCHW",
+ )
+
+ # check for output types
+ assert type(graph) is str
+ assert type(lib) is tvm.runtime.module.Module
+ assert type(params) is dict
+ assert type(dumps) is dict
Review comment:
Those checks look no cover anything special? To me, as long as you can compile the model without errors, then you should have used the right target host.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] comaniac commented on a change in pull request #6855: [TVMC] use target_host when it is set
Posted by GitBox <gi...@apache.org>.
comaniac commented on a change in pull request #6855:
URL: https://github.com/apache/incubator-tvm/pull/6855#discussion_r527859587
##########
File path: tests/python/driver/tvmc/test_compiler.py
##########
@@ -150,3 +150,21 @@ def test_cross_compile_aarch64_onnx_module(onnx_resnet50):
assert type(params) is dict
assert type(dumps) is dict
assert "asm" in dumps.keys()
+
+
+@tvm.testing.requires_opencl
+def test_compile_opencl(tflite_mobilenet_v1_0_25_128):
+ pytest.importorskip("tflite")
+
+ graph, lib, params, dumps = tvmc.compiler.compile_model(
+ tflite_mobilenet_v1_0_25_128,
+ target="opencl",
+ target_host="llvm",
+ alter_layout="NCHW",
+ )
+
+ # check for output types
+ assert type(graph) is str
+ assert type(lib) is tvm.runtime.module.Module
+ assert type(params) is dict
+ assert type(dumps) is dict
Review comment:
Those checks look not cover anything special? To me, as long as you can compile the model without errors, then you should have used the right target host.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] comaniac commented on pull request #6855: [TVMC] use target_host when it is set
Posted by GitBox <gi...@apache.org>.
comaniac commented on pull request #6855:
URL: https://github.com/apache/incubator-tvm/pull/6855#issuecomment-729067658
@euntaik please address the review comments.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org