[GitHub] [calcite] bchapuis commented on a diff in pull request #2989: [CALCITE-5280] Add geometry aggregate functions (ST_Accum, ST_Collect, and ST_Union)

[GitBox <gi...@apache.org>]

bchapuis commented on code in PR #2989:
URL: https://github.com/apache/calcite/pull/2989#discussion_r1037646857


##########
core/src/main/java/org/apache/calcite/sql/fun/SqlLibraryOperatorTableFactory.java:
##########
@@ -16,6 +16,15 @@
  */
 package org.apache.calcite.sql.fun;
 
+import org.apache.calcite.config.CalciteConnectionConfigImpl;
+import org.apache.calcite.jdbc.CalciteSchema;
+import org.apache.calcite.jdbc.JavaTypeFactoryImpl;
+import org.apache.calcite.model.ModelHandler;
+import org.apache.calcite.prepare.CalciteCatalogReader;
+import org.apache.calcite.runtime.SpatialTypeFunctions;
+import org.apache.calcite.schema.Function;
+import org.apache.calcite.schema.SchemaPlus;

Review Comment:
   I aggree, this code should have been placed in `SqlOPeratorTables.createSpatial`. However, as it does not address the number of imports, I looked at the `SqlStdOperatorTable` and wondered if we should create a `SqlSpatialOperatorTable`. I will probably dig into this a bit, but please stop me if it is a bad idea.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org