[GitHub] [kafka] divijvaidya commented on a diff in pull request #13742: KAFKA-14996: Handle overly large user operations on the kcontroller

["divijvaidya (via GitHub)" <gi...@apache.org>]

divijvaidya commented on code in PR #13742:
URL: https://github.com/apache/kafka/pull/13742#discussion_r1203739372


##########
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java:
##########
@@ -160,6 +161,14 @@
  * the controller can fully initialize.
  */
 public final class QuorumController implements Controller {
+    /**
+     * The maximum records any user-initiated operation is allowed to generate.
+     */
+    final static int MAX_RECORDS_PER_USER_OP = 10000;

Review Comment:
   Please add a detailed comment explaining how this number was calculated. It would help future authors to understand the considerations to take into account while changing it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org