You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/06/06 15:12:28 UTC
[GitHub] [apisix-ingress-controller] stillfox-lee opened a new pull request, #1068: doc: add v2 ApisixRoute reference
stillfox-lee opened a new pull request, #1068:
URL: https://github.com/apache/apisix-ingress-controller/pull/1068
<!-- Please answer these questions before submitting a pull request -->
### Type of change:
<!-- Please delete options that are not relevant. -->
- [ ] Bugfix
- [ ] New feature provided
- [ ] Improve performance
- [ ] Backport patches
### What this PR does / why we need it:
<!--- Why is this change required? What problem does it solve? -->
<!--- If it fixes an open issue, please link to the issue here. -->
[issue](https://github.com/apache/apisix-ingress-controller/issues/1063)
I just copy from api_route_v2beta3.md. And add some new rows that already exist in https://github.com/apache/apisix-ingress-controller/blob/d3a823f590843468a555ccc68502acc568d9a9f3/samples/deploy/crd/v1/ApisixRoute.yaml#L563.
### Pre-submission checklist:
<!--
Please follow the requirements:
1. Use Draft if the PR is not ready to be reviewed
2. Test is required for the feat/fix PR, unless you have a good reason
3. Doc is required for the feat PR
4. Use a new commit to resolve review instead of `push -f`
5. Use "request review" to notify the reviewer once you have resolved the review
-->
* [ ] Did you explain what problem does this PR solve? Or what new features have been added?
* [ ] Have you added corresponding test cases?
* [ ] Have you modified the corresponding document?
* [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix-ingress-controller#community) first**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on pull request #1068: doc: add v2 ApisixRoute reference
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on PR #1068:
URL: https://github.com/apache/apisix-ingress-controller/pull/1068#issuecomment-1148308039
@stillfox-lee If you pull the latest code from the master branch, you will see the CRD configuration of ApisixPluginConfig v2.
For ApisixUpstream, it can be ignored because we haven't added the v2 implementation yet. until #944 merged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on a diff in pull request #1068: doc: add v2 ApisixRoute reference
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on code in PR #1068:
URL: https://github.com/apache/apisix-ingress-controller/pull/1068#discussion_r903874636
##########
docs/en/latest/references/apisix_cluster_config_v2beta3.md:
##########
@@ -0,0 +1,38 @@
+---
+title: ApisixClusterConfig/v2alpha1 Reference
Review Comment:
```suggestion
title: ApisixClusterConfig/v2beta3 Reference
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on a diff in pull request #1068: doc: add v2 ApisixRoute reference
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on code in PR #1068:
URL: https://github.com/apache/apisix-ingress-controller/pull/1068#discussion_r903876619
##########
docs/en/latest/references/apisix_tls_v2beta3.md:
##########
@@ -0,0 +1,34 @@
+---
+title: ApisixTls Reference
Review Comment:
```suggestion
title: ApisixTls/v2beta3 Reference
```
##########
docs/en/latest/references/apisix_route_v2.md:
##########
@@ -0,0 +1,99 @@
+---
+title: ApisixRoute/v2beta3 Reference
Review Comment:
```suggestion
title: ApisixRoute/v2 Reference
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] stillfox-lee commented on pull request #1068: doc: add v2 ApisixRoute reference
Posted by GitBox <gi...@apache.org>.
stillfox-lee commented on PR #1068:
URL: https://github.com/apache/apisix-ingress-controller/pull/1068#issuecomment-1148299914
Hi @tao12345666333 , I have a question about our CRD version 2.
In ApisixPluginConfig and ApisixUpstream CRD yaml. There are no v2 but only v2beta3. Maybe we should define v2 CRD then add v2 documentation? Otherwise, doc and our implementation are not unified.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on pull request #1068: doc: add v2 ApisixRoute reference
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on PR #1068:
URL: https://github.com/apache/apisix-ingress-controller/pull/1068#issuecomment-1148114781
Don't worry, ping me if you need any help
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-commenter commented on pull request #1068: doc: add v2 ApisixRoute reference
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #1068:
URL: https://github.com/apache/apisix-ingress-controller/pull/1068#issuecomment-1148826638
# [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1068?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1068](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1068?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7cceb18) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/8d764286b018c22b20b62591b7bb68b93de0a93b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8d76428) will **not change** coverage.
> The diff coverage is `n/a`.
> :exclamation: Current head 7cceb18 differs from pull request most recent head 5446e8b. Consider uploading reports for the commit 5446e8b to get more accurate results
```diff
@@ Coverage Diff @@
## master #1068 +/- ##
=======================================
Coverage 30.83% 30.83%
=======================================
Files 77 77
Lines 9140 9140
=======================================
Hits 2818 2818
Misses 6019 6019
Partials 303 303
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1068?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1068?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [deb0440...5446e8b](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1068?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on pull request #1068: doc: add v2 ApisixRoute reference
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on PR #1068:
URL: https://github.com/apache/apisix-ingress-controller/pull/1068#issuecomment-1163229521
@stillfox-lee could you please update the index? Just add all of these filenames
https://github.com/apache/apisix-ingress-controller/blob/50d6026df3953f9005bdd6ce4055909d0b2e3310/docs/en/latest/config.json#L35-L42
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] stillfox-lee commented on pull request #1068: doc: add v2 ApisixRoute reference
Posted by GitBox <gi...@apache.org>.
stillfox-lee commented on PR #1068:
URL: https://github.com/apache/apisix-ingress-controller/pull/1068#issuecomment-1149782493
> I can merge the commit records for you later, so that files unrelated to your changes will not appear in the review list
Oh, I see. Sorry about that. I'm not familiar with PR workflow. I should just merge upstream to my origin and then commit to the origin branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] stillfox-lee commented on pull request #1068: doc: add v2 ApisixRoute reference
Posted by GitBox <gi...@apache.org>.
stillfox-lee commented on PR #1068:
URL: https://github.com/apache/apisix-ingress-controller/pull/1068#issuecomment-1148060865
> Can you help to add the v2 documentation for the other resources as well?
Sure. Sorry for missing the other resources.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 merged pull request #1068: doc: add v2 ApisixRoute reference
Posted by GitBox <gi...@apache.org>.
tao12345666333 merged PR #1068:
URL: https://github.com/apache/apisix-ingress-controller/pull/1068
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on pull request #1068: doc: add v2 ApisixRoute reference
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on PR #1068:
URL: https://github.com/apache/apisix-ingress-controller/pull/1068#issuecomment-1147637757
Can you help to add the v2 documentation for the other resources as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on pull request #1068: doc: add v2 ApisixRoute reference
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on PR #1068:
URL: https://github.com/apache/apisix-ingress-controller/pull/1068#issuecomment-1149617507
I can merge the commit records for you later, so that files unrelated to your changes will not appear in the review list
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] stillfox-lee commented on pull request #1068: doc: add v2 ApisixRoute reference
Posted by GitBox <gi...@apache.org>.
stillfox-lee commented on PR #1068:
URL: https://github.com/apache/apisix-ingress-controller/pull/1068#issuecomment-1148321788
> @stillfox-lee If you pull the latest code from the master branch, you will see the CRD configuration of ApisixPluginConfig v2.
>
> For ApisixUpstream, it can be ignored because we haven't added the v2 implementation yet. until #944 merged
Got it, thx.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] stillfox-lee commented on pull request #1068: doc: add v2 ApisixRoute reference
Posted by GitBox <gi...@apache.org>.
stillfox-lee commented on PR #1068:
URL: https://github.com/apache/apisix-ingress-controller/pull/1068#issuecomment-1149782494
> I can merge the commit records for you later, so that files unrelated to your changes will not appear in the review list
Oh, I see. Sorry about that. I'm not familiar with PR workflow. I should just merge upstream to my origin and then commit to the origin branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on pull request #1068: doc: add v2 ApisixRoute reference
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on PR #1068:
URL: https://github.com/apache/apisix-ingress-controller/pull/1068#issuecomment-1163225416
Sorry for delay.
I have updated the commit records in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org