[GitHub] [hbase] shardul-cr7 commented on a change in pull request #571: HBASE-20821 Re-creating a dropped namespace and contained table inherits previously set space quota settings

[GitBox <gi...@apache.org>]

shardul-cr7 commented on a change in pull request #571: HBASE-20821 Re-creating a dropped namespace and contained table inherits previously set space quota settings
URL: https://github.com/apache/hbase/pull/571#discussion_r321080845
 
 

 ##########
 File path: hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/MasterQuotasObserver.java
 ##########
 @@ -78,6 +79,20 @@ public void postDeleteTable(
           admin.setQuota(settings);
         }
       }
+    } else if (quotasAtNamespace != null) {
+      // If quota present at namespace level remove the table entry from 'hbase:quota'
 
 Review comment:
   Because even though table is dropped it's entry is still present in the 'hbase:quota' table because of the namespace quota. If we create another table with same name inside that namespace it inherits the earlier quota settings. So during dropping the table we need to remove that entry/setting from the hbase:quota for our table even though quota was present at namespace level.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services